From: Marco Trudel <mtrudel@gmx.ch>
To: gnustuff@thisiscool.com
Cc: java-patches@gcc.gnu.org
Subject: Re: Patch [MinGW] FYI: #undef OUT (was Re: jdwp build failure)
Date: Thu, 22 Feb 2007 14:25:00 -0000 [thread overview]
Message-ID: <45DDA7D3.4070209@gmx.ch> (raw)
In-Reply-To: <3YB00D9GDB9OOJHFGEA9WVNJD81YB9.45dda634@parallels>
Mohan Embar wrote:
> Hi All,
>
> -->Mohan wrote:
>>>> I had already tried that, but it didn't work. I had even put an
>>>> #undef OUT in the offending .cc file with no luck. Still, if it
>>>> only happens on Win32, it has to be a macro, right?.
>>>> I've only made half-hearted attempts here.
>
> Ouch. I guess I hadn't put the #undef OUT in the right place. Thanks
> for catching this, Marco. And thanks for your insight, Danny.
>
> -->Marco wrote:
>> Also "OUT" is a common widespread word and might lead to conflicts in
>> future too.
>
> Yes, but we're doing this for other such macros in win32-thread.h already.
>
> I've committed the following patch, which seems to unbreak the build.
Thanks :-)
> Sorry I've been so distracted lately.
No problem...
Marco
> -- Mohan
> http://www.thisiscool.com/
> http://www.animalsong.org/
>
> 2007-02-22 Mohan Embar <gnustuff@thisiscool.com>
>
> * include/win32-threads.h: Added #undef OUT.
>
> Index: include/win32-threads.h
> ===================================================================
> --- include/win32-threads.h (revision 122226)
> +++ include/win32-threads.h (working copy)
> @@ -227,5 +227,6 @@
> #undef STRICT
> #undef VOID
> #undef TEXT
> +#undef OUT
>
> #endif /* __JV_WIN32_THREADS__ */
>
>
>
prev parent reply other threads:[~2007-02-22 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 8:12 jdwp build failure Danny Smith
2007-02-22 8:21 ` Marco Trudel
2007-02-22 14:18 ` Patch [MinGW] FYI: #undef OUT (was Re: jdwp build failure) Mohan Embar
2007-02-22 14:25 ` Marco Trudel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DDA7D3.4070209@gmx.ch \
--to=mtrudel@gmx.ch \
--cc=gnustuff@thisiscool.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).