From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-18127-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28684 invoked by alias); 22 Feb 2007 14:25:38 -0000
Received: (qmail 28669 invoked by uid 22791); 22 Feb 2007 14:25:38 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20)     by sourceware.org (qpsmtpd/0.31) with SMTP; Thu, 22 Feb 2007 14:25:31 +0000
Received: (qmail invoked by alias); 22 Feb 2007 14:25:29 -0000
Message-ID: <45DDA7D3.4070209@gmx.ch>
Date: Thu, 22 Feb 2007 14:25:00 -0000
From: Marco Trudel <mtrudel@gmx.ch>
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
MIME-Version: 1.0
To:  gnustuff@thisiscool.com
CC:  java-patches@gcc.gnu.org
Subject: Re: Patch [MinGW] FYI: #undef OUT (was Re: jdwp build failure)
References: <3YB00D9GDB9OOJHFGEA9WVNJD81YB9.45dda634@parallels>
In-Reply-To: <3YB00D9GDB9OOJHFGEA9WVNJD81YB9.45dda634@parallels>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-IsSubscribed: yes
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2007-q1/txt/msg00604.txt.bz2

Mohan Embar wrote:
> Hi All,
> 
> -->Mohan wrote:
>>>> I had already tried that, but it didn't work. I had even put an
>>>> #undef OUT in the offending .cc file with no luck. Still, if it
>>>> only happens on Win32, it has to be a macro, right?.
>>>> I've only made half-hearted attempts here.
> 
> Ouch. I guess I hadn't put the #undef OUT in the right place. Thanks
> for catching this, Marco. And thanks for your insight, Danny.
> 
> -->Marco wrote:
>> Also "OUT" is a common widespread word and might lead to conflicts in
>> future too.
> 
> Yes, but we're doing this for other such macros in win32-thread.h already.
> 
> I've committed the following patch, which seems to unbreak the build.

Thanks :-)


> Sorry I've been so distracted lately.

No problem...


Marco

> -- Mohan
> http://www.thisiscool.com/
> http://www.animalsong.org/
> 
> 2007-02-22  Mohan Embar  <gnustuff@thisiscool.com>
> 
> 	* include/win32-threads.h: Added #undef OUT.
> 
> Index: include/win32-threads.h
> ===================================================================
> --- include/win32-threads.h	(revision 122226)
> +++ include/win32-threads.h	(working copy)
> @@ -227,5 +227,6 @@
>  #undef STRICT
>  #undef VOID
>  #undef TEXT
> +#undef OUT
>  
>  #endif /* __JV_WIN32_THREADS__ */
> 
> 
>