From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24444 invoked by alias); 6 Mar 2007 21:10:53 -0000 Received: (qmail 24434 invoked by uid 22791); 6 Mar 2007 21:10:51 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Mar 2007 21:10:43 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l26LAf9C012333 for ; Tue, 6 Mar 2007 16:10:41 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26LAenD025912 for ; Tue, 6 Mar 2007 16:10:40 -0500 Received: from [172.16.14.97] (toycar.toronto.redhat.com [172.16.14.97]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l26LAe8j025606 for ; Tue, 6 Mar 2007 16:10:40 -0500 Message-ID: <45EDD8D0.1080001@redhat.com> Date: Tue, 06 Mar 2007 21:10:00 -0000 From: Kyle Galloway User-Agent: Thunderbird 1.5.0.9 (X11/20061219) MIME-Version: 1.0 To: java-patches@gcc.gnu.org Subject: Re: [RFA] JDWP VMMethod::getVariableTable References: <45DDDDCF.1050802@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2007-q1/txt/msg00642.txt.bz2 Tom Tromey wrote: >>>>>> "Kyle" == Kyle Galloway writes: >>>>>> > > Kyle> The CHECK_INTERP_CLASS macro ensures that the class of the > Kyle> method is interpreted. > > I think getLineTable should be updated to use the new macro. > > Kyle> + String *msg = reinterpret_cast (JvNewStringUTF (error)); > > I think you shouldn't need the cast here. > > Aside from these, this is ok. Thanks. I made those small changes and have committed this patch. Thanks, Kyle