* [RFA] Fix JDWP ThreadReference.Resume
@ 2007-03-28 19:24 Kyle Galloway
2007-03-30 19:06 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Kyle Galloway @ 2007-03-28 19:24 UTC (permalink / raw)
To: GCJ-patches
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
This trivial patch fixes an error that would result in the inability for
JDWP to resume threads. Currently, when JDWP goes to "resume" a thread,
it will call suspend on it again which will just increase the suspend
count, not cause the thread to resume. This went into Classpath
yesterday, and I think it's important enough we should fix it here.
ChangeLog
2007-03-28 Kyle Galloway <kgallowa@redhat.com>
* classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java
(executeResume): Call VMVirtualMachince.resumeThread.
Questions/comments/concerns?
- Kyle
[-- Attachment #2: suspendfix.patch --]
[-- Type: text/x-patch, Size: 630 bytes --]
Index: libjava/classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java
===================================================================
--- libjava/classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java (revision 123266)
+++ libjava/classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java (working copy)
@@ -142,7 +142,7 @@
{
ThreadId tid = (ThreadId) idMan.readObjectId(bb);
Thread thread = tid.getThread();
- VMVirtualMachine.suspendThread(thread);
+ VMVirtualMachine.resumeThread(thread);
}
private void executeStatus(ByteBuffer bb, DataOutputStream os)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Fix JDWP ThreadReference.Resume
2007-03-28 19:24 [RFA] Fix JDWP ThreadReference.Resume Kyle Galloway
@ 2007-03-30 19:06 ` Tom Tromey
2007-04-02 12:54 ` Kyle Galloway
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2007-03-30 19:06 UTC (permalink / raw)
To: Kyle Galloway; +Cc: GCJ-patches
>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:
Kyle> ChangeLog
Kyle> 2007-03-28 Kyle Galloway <kgallowa@redhat.com>
Kyle> * classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java
Kyle> (executeResume): Call VMVirtualMachince.resumeThread.
Kyle> Questions/comments/concerns?
The patch looks good.
The ChangeLog entry looks misformatted -- the whitespace at the start
of a line should be a tab character.
thanks,
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Fix JDWP ThreadReference.Resume
2007-03-30 19:06 ` Tom Tromey
@ 2007-04-02 12:54 ` Kyle Galloway
0 siblings, 0 replies; 3+ messages in thread
From: Kyle Galloway @ 2007-04-02 12:54 UTC (permalink / raw)
To: tromey; +Cc: GCJ-patches
Tom Tromey wrote:
>>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:
>>>>>>
>
> Kyle> ChangeLog
> Kyle> 2007-03-28 Kyle Galloway <kgallowa@redhat.com>
> Kyle> * classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java
> Kyle> (executeResume): Call VMVirtualMachince.resumeThread.
>
> Kyle> Questions/comments/concerns?
>
> The patch looks good.
> The ChangeLog entry looks misformatted -- the whitespace at the start
> of a line should be a tab character.
My mailer uses 3 spaces for a tab, so unfortunately ChangeLogs in my
e-mails will likely be mangled.
This patch has been committed.
Thanks,
Kyle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-02 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-28 19:24 [RFA] Fix JDWP ThreadReference.Resume Kyle Galloway
2007-03-30 19:06 ` Tom Tromey
2007-04-02 12:54 ` Kyle Galloway
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).