From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17023 invoked by alias); 28 Jan 2008 04:38:44 -0000 Received: (qmail 17008 invoked by uid 22791); 28 Jan 2008 04:38:43 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.dnsmadeeasy.com (HELO smtp1.dnsmadeeasy.com) (205.234.170.144) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Jan 2008 04:38:23 +0000 Received: from smtp1.dnsmadeeasy.com (localhost [127.0.0.1]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP id 85137311A0E; Mon, 28 Jan 2008 04:38:22 +0000 (UTC) X-Authenticated-Name: js.dnsmadeeasy X-Transit-System: In case of SPAM please contact abuse@dnsmadeeasy.com Received: from avtrex.com (unknown [67.116.42.147]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP; Mon, 28 Jan 2008 04:38:22 +0000 (UTC) Received: from [192.168.7.228] ([192.168.7.228]) by avtrex.com with Microsoft SMTPSVC(6.0.3790.1830); Sun, 27 Jan 2008 20:38:19 -0800 Message-ID: <479D5C3B.9070900@avtrex.com> Date: Mon, 28 Jan 2008 04:38:00 -0000 From: David Daney User-Agent: Thunderbird 1.5.0.12 (X11/20071019) MIME-Version: 1.0 To: Andrew Haley , java-patches@gcc.gnu.org Cc: Gerald Pfeifer , Tom Tromey , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libjava: Add option to disable BC ABI in libgcj. References: <476C3D6A.6060704@avtrex.com> <479AC29F.9050909@avtrex.com> <479B1090.9090307@redhat.com> <479BAB00.2000202@avtrex.com> <479C5E29.6000607@redhat.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------090300000702040709000204" X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2008-q1/txt/msg00041.txt.bz2 This is a multi-part message in MIME format. --------------090300000702040709000204 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 734 Gerald Pfeifer wrote: > On Sun, 27 Jan 2008, Andrew Haley wrote: > >>> I don't think so, but I have a limited grasp of the English language. I >>> will defer to others on which of 'affected' or 'effected' should be used >>> here. >>> >> OK, so take it from me: it's "affected". >> > > ;-) David, I assume Andrew is going to give the final Ack for the patch > (or has done so already). Just make sure you won't stall on me, I was > mainly trying to give some feedback. > OK. Andrew, it's in your hands now. How about this version? The only change is to use 'affected' instead off 'effected'. 2008-01-27 David Daney * doc/install.texi (--disable-libgcj-bc): Reword documentation. --------------090300000702040709000204 Content-Type: text/x-patch; name="libgcj-bc-doc.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="libgcj-bc-doc.diff" Content-length: 1018 Index: doc/install.texi =================================================================== --- doc/install.texi (revision 131882) +++ doc/install.texi (working copy) @@ -1557,12 +1557,13 @@ Disable JVMPI support. @item --disable-libgcj-bc Disable BC ABI compilation of certain parts of libgcj. By default, some portions of libgcj are compiled with @option{-findirect-dispatch} -@option{-fno-indirect-classes}. This allows them to be overridden at -runtime. +and @option{-fno-indirect-classes}, allowing them to be overridden at +run-time. If @option{--disable-libgcj-bc} is specified, libgcj is built without -these options. This makes it impossible to override portions of -libgcj at runtime, but can make it easier to statically link to libgcj. +these options. This allows the compile-time linker to resolve +dependencies when statically linking to libgcj. However it makes it +impossible to override the affected portions of libgcj at run-time. @item --with-ecos Enable runtime eCos target support. --------------090300000702040709000204--