From: Matthias Klose <doko@ubuntu.com>
To: Joshua Sumali <jsumali@redhat.com>
Cc: java-patches@gcc.gnu.org, Thomas Fitzsimmons <fitzsim@redhat.com>
Subject: Re: [patch] Create sdk style directory on install
Date: Fri, 13 Jun 2008 12:42:00 -0000 [thread overview]
Message-ID: <48526AFA.3080800@ubuntu.com> (raw)
In-Reply-To: <48518D6E.8060302@redhat.com>
Joshua Sumali schrieb:
> Hi,
>
> Attached is a patch to create a sdk style directory when
> --enable-java-home is passed to configure. The patch is basically a
> merge of java-gcj-compat into libgcj.
>
> To have this work, at the minimum, pass the following to ./configure:
> --enable-java-home --with-arch-directory=(your arch).
> --with-arch-directory specifies what to use for the
> java-1.5.0-gcj-1.5.0.0/jre/lib/<arch> directory (e.g. I use i386).
>
> I've only included the diff to configure.ac and Makefile.am since
> including the configure and Makefile.in makes the patch quite big, so be
> sure to autoconf && automake before trying this patch. I can upload the
> renerated files somewhere if it's absolutely needed, though.
- please use `transform' to install the binaries; just using gcc_suffix is
inconsistant with current installation. Same for using GIJ_VERSION.
- symlinks for man pages are not installed. intended?
- + for jarname in jaas jce jdbc-stdext jndi jndi-cos jndi-dns ...
I think this is fedora specific to support jpackage? It doesn't hurt
to have these symlinks. Maybe the same should be added for IcedTea?
- Is the --with-arch-directory really needed? Shouldn't we just use the
default.
+
jre_dir=java-${JAVA_VERSION}-${origin_name}-${JAVA_VERSION}.${BUILD_VERSION}${arch_suffix}/jre
+
sdk_dir=java-${JAVA_VERSION}-${origin_name}-${JAVA_VERSION}.${BUILD_VERSION}${arch_suffix}
+ jre_lnk=jre-${JAVA_VERSION}-${origin_name}
+ sdk_lnk=java-${JAVA_VERSION}-${origin_name}
why using the long version at all? afaik no packaging allows installation of two
such packages at the same time (with same jre_link and different jre_dir's). And
it makes it difficult for people writing into the ext subdirectory because this
changes across minor version upgrades.
- The new configure options should be documented in gcc/doc/install.texi
(and maybe something about the jpackage compatible (?) layout).
- what is the rationale of --with-jvm-jar-dir ?
Matthias
next prev parent reply other threads:[~2008-06-13 12:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 20:56 Joshua Sumali
2008-06-13 10:42 ` Andrew Haley
2008-06-13 12:42 ` Matthias Klose [this message]
2008-06-16 14:37 ` Joshua Sumali
2008-06-18 20:39 ` Joshua Sumali
2008-06-19 9:54 ` Andrew Haley
2008-06-19 14:24 ` Joshua Sumali
2008-06-20 4:13 ` Joshua Sumali
2008-06-26 18:18 ` Joshua Sumali
2008-06-30 10:20 ` Andrew Haley
2008-06-30 13:54 ` Joshua Sumali
2008-06-30 13:57 ` Andrew Haley
2008-06-30 14:39 ` Joshua Sumali
2008-07-01 13:59 ` Andrew Haley
2008-07-01 14:53 ` Joshua Sumali
2008-07-01 15:01 ` Andrew Haley
2008-07-02 13:07 ` Andrew Haley
2008-07-02 13:19 ` Joshua Sumali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48526AFA.3080800@ubuntu.com \
--to=doko@ubuntu.com \
--cc=fitzsim@redhat.com \
--cc=java-patches@gcc.gnu.org \
--cc=jsumali@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).