public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Haley <aph@redhat.com>
To: Joshua Sumali <jsumali@redhat.com>
Cc: java-patches@gcc.gnu.org
Subject: Re: [patch] Create sdk style directory on install
Date: Tue, 01 Jul 2008 15:01:00 -0000	[thread overview]
Message-ID: <486A469C.8060200@redhat.com> (raw)
In-Reply-To: <486A44CD.7030807@redhat.com>

Joshua Sumali wrote:
> Andrew Haley wrote:
>> Joshua Sumali wrote:
>>  
>>> Andrew Haley wrote:
>>>    
>>>> Joshua Sumali wrote:
>>>>  
>>>>      
>>>>> Andrew Haley wrote:
>>>>>             
>>>>  
>>>>      
>>>>>> Please assign all Red Hat copyrights to the FSF.
>>>>>>                   
>>>>> Is there a special way to do this, or do I simply change "Copyright
>>>>> (C)
>>>>> 2005, 2006, 2008 Red Hat, Inc." to "Copyright (C) 2005, 2006, 2008
>>>>> Free
>>>>> Software Foundation" on the appropriate files?
>>>>>             
>>>> That's all you have to do.
>>>>
>>>>  
>>>>      
>>>>>> Do I take it that you don't have commit access to the gcc tree?
>>>>>>                   
>>>>> I do not. I was hoping someone would be able to commit the patches
>>>>> for me.
>>>>>             
>>>> I'll do it.
>>>>
>>>> Andrew.
>>>>
>>>>         
>>> Copyrights assigned to FSF. ChangeLogs removed from patches and are
>>> found below.
>>>     
>>
>> I get:
>>
>>
>>  $ automake
>> Makefile.am:67: JAVA_HOME_DIR was already defined in condition TRUE,
>> which includes condition JAVA_HOME_SET ...
>> configure.ac:1759: ... `JAVA_HOME_DIR' previously defined here
>> Makefile.am:70: JAVA_HOME_DIR was already defined in condition TRUE,
>> which includes condition !JAVA_HOME_SET ...
>>
>>
>>   
> Sorry, my mistake for leaving that in. To fix that, remove the following
> lines from configure.ac:
> 
> JAVA_HOME_DIR=${jvm_root_dir}/${jre_dir}
> AC_SUBST(JAVA_HOME_DIR)
> AC_MSG_RESULT(JAVA_HOME directory: ${JAVA_HOME_DIR})
> 
> They should be around line 1759.
> 
> (I'd post another patch but I figured that it would be easier to just
> delete those few lines)

OK, TVM.

Andrew.

  reply	other threads:[~2008-07-01 15:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 20:56 Joshua Sumali
2008-06-13 10:42 ` Andrew Haley
2008-06-13 12:42 ` Matthias Klose
2008-06-16 14:37   ` Joshua Sumali
2008-06-18 20:39     ` Joshua Sumali
2008-06-19  9:54       ` Andrew Haley
2008-06-19 14:24         ` Joshua Sumali
2008-06-20  4:13           ` Joshua Sumali
2008-06-26 18:18           ` Joshua Sumali
2008-06-30 10:20             ` Andrew Haley
2008-06-30 13:54               ` Joshua Sumali
2008-06-30 13:57                 ` Andrew Haley
2008-06-30 14:39                   ` Joshua Sumali
2008-07-01 13:59                     ` Andrew Haley
2008-07-01 14:53                       ` Joshua Sumali
2008-07-01 15:01                         ` Andrew Haley [this message]
2008-07-02 13:07                     ` Andrew Haley
2008-07-02 13:19                       ` Joshua Sumali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486A469C.8060200@redhat.com \
    --to=aph@redhat.com \
    --cc=java-patches@gcc.gnu.org \
    --cc=jsumali@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).