From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25679 invoked by alias); 24 Aug 2008 20:09:12 -0000 Received: (qmail 25659 invoked by uid 22791); 24 Aug 2008 20:09:11 -0000 X-Spam-Check-By: sourceware.org Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 24 Aug 2008 20:08:22 +0000 Received: from wolfram.andreas.nets ([91.190.8.131]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id m7OK8Her069262; Sun, 24 Aug 2008 22:08:18 +0200 (CEST) (envelope-from andreast-list@fgznet.ch) Message-ID: <48B1BFB1.6010407@fgznet.ch> Date: Sun, 24 Aug 2008 22:04:00 -0000 From: Andreas Tobler User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707) MIME-Version: 1.0 To: David Edelsohn CC: GCC Patches , Java Patches Subject: Re: [patch] libffi, fix powerpc-unknown-freebsd References: <303e1d290808200807p62fd1a4btc253c532e749da30@mail.gmail.com> <48ADE3EE.3080807@fgznet.ch> <303e1d290808211732l4fe287dfmb4c73ae3233dbd5c@mail.gmail.com> In-Reply-To: <303e1d290808211732l4fe287dfmb4c73ae3233dbd5c@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2008-q3/txt/msg00058.txt.bz2 David Edelsohn wrote: > On Thu, Aug 21, 2008 at 5:53 PM, Andreas Tobler wrote: >> Instead of playing with FFI_SYSV_TYPE_SMALL_STRUCT for bit shifts I >> introduced two new flags which tell us if we need r3 or r3 and r4 for >> structs passing. >> >> The issue is this, I need to tell the ppc_closure.S exactly which type I >> expect when returning. And unfortunatley the implementation needs a >> distinction for every type and size. Type 1 to 15 are already used, so I can >> start with using type 16 and up. > > I mainly want a comment that two bits are used, especially in > ffitarget.h. Thanks for the additional explanation. Thanks for review. I have an understanding issue here, what bits are you referring to? The FLAG_SYSV_SMST_R4 and FLAG_SYSV_SMST_R3 from ffi.c? Or the situation that I use FFI_SYSV_TYPE_SMALL_STRUCT and the two flags? If the former, then my impression is that they don't need to be mentioned in ffitarget.h, otherwise we'd have to describe every flag used in ffi.c in ffitarget.h as well. If the latter, I can put a note into ffitarget.h mentioning that we need additional separation in ffi.c to clearly distinguish what we return. Else, if I completely misunderstood you, would you mind explaining me what you would like to read? Thanks in advance, Andreas