From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31986 invoked by alias); 4 Sep 2008 16:12:52 -0000 Received: (qmail 31975 invoked by uid 22791); 4 Sep 2008 16:12:51 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Sep 2008 16:12:16 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m84GBqfg000843; Thu, 4 Sep 2008 12:11:52 -0400 Received: from zebedee.pink (vpn-13-96.rdu.redhat.com [10.11.13.96]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m84GBlbo022068; Thu, 4 Sep 2008 12:11:49 -0400 Message-ID: <48C008C3.5000300@redhat.com> Date: Thu, 04 Sep 2008 16:25:00 -0000 From: Andrew Haley User-Agent: Thunderbird 2.0.0.16 (X11/20080707) MIME-Version: 1.0 To: David Daney CC: Java Patch List Subject: Re: Remove data race in libgcj interpreter References: <48AD67B2.4040308@redhat.com> <48C0042C.5080804@redhat.com> <48C00606.2040205@avtrex.com> In-Reply-To: <48C00606.2040205@avtrex.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2008-q3/txt/msg00072.txt.bz2 David Daney wrote: > Andrew Haley wrote: >> + >> + #ifdef DIRECT_THREADED >> + CHECK_INSN (&&insn_instanceof); >> + #endif /* DIRECT_THREADED */ >> + > > Just a little style pedantry... > > Should we re-write the CHECK_INSN macro so that it is a nop ifndef > DIRECT_THREADED? > > That would make the many places you have this construct look much cleaner. OK, but would it be easier to understand when reading the code? That's why I didn't do that. Sometimes clarity and cleanliness don't go together. What do you think? Andrew.