From: David Daney <ddaney@avtrex.com>
To: Andrew Haley <aph@redhat.com>
Cc: Java Patch List <java-patches@gcc.gnu.org>
Subject: Re: Remove data race in libgcj interpreter
Date: Thu, 04 Sep 2008 18:37:00 -0000 [thread overview]
Message-ID: <48C00BE2.3050702@avtrex.com> (raw)
In-Reply-To: <48C008C3.5000300@redhat.com>
Andrew Haley wrote:
> David Daney wrote:
>> Andrew Haley wrote:
>>> +
>>> + #ifdef DIRECT_THREADED
>>> + CHECK_INSN (&&insn_instanceof);
>>> + #endif /* DIRECT_THREADED */
>>> +
>> Just a little style pedantry...
>>
>> Should we re-write the CHECK_INSN macro so that it is a nop ifndef
>> DIRECT_THREADED?
>>
>> That would make the many places you have this construct look much cleaner.
>
> OK, but would it be easier to understand when reading the code? That's
> why I didn't do that. Sometimes clarity and cleanliness don't go
> together. What do you think?
For me there are two issues:
1) Mutex free synchronization scares me. But That part of the patch
seems plausible.
2) Of much less importance is the question of littering the code with
#ifdef. I stated my preference, but don't feel strongly enough about it
that I would be offended if your original patch were committed.
David Daney
next prev parent reply other threads:[~2008-09-04 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 13:31 Andrew Haley
2008-08-21 21:54 ` Andrew Haley
2008-08-22 12:12 ` gij: more thread-safety fixes Andrew Haley
2008-08-22 12:51 ` Remove data race in libgcj interpreter Bryce McKinlay
2008-08-24 1:46 ` Andrew Haley
2008-09-04 16:00 ` Andrew Haley
2008-09-04 16:12 ` David Daney
2008-09-04 16:25 ` Andrew Haley
2008-09-04 18:37 ` David Daney [this message]
2008-09-05 9:39 ` Boehm, Hans
2008-09-05 11:28 ` Andrew Haley
2008-09-06 9:26 ` Hans Boehm
2008-09-08 17:42 ` Andrew Haley
2008-09-22 14:25 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C00BE2.3050702@avtrex.com \
--to=ddaney@avtrex.com \
--cc=aph@redhat.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).