From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130723 invoked by alias); 21 Nov 2016 12:57:58 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 130700 invoked by uid 89); 21 Nov 2016 12:57:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=21112016, 21.11.2016, bdwgc32, bdw-gc,32 X-Spam-User: qpsmtpd, 2 recipients X-HELO: einhorn.in-berlin.de Received: from einhorn.in-berlin.de (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Nov 2016 12:57:46 +0000 X-Envelope-From: doko@ubuntu.com Received: from [192.168.178.26] (ip5f5af460.dynamic.kabel-deutschland.de [95.90.244.96]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id uALCvZec002847 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 21 Nov 2016 13:57:35 +0100 Subject: Re: [PATCH] Delete GCJ To: Iain Sandoe References: <78f841e7-808b-58d0-7913-3ec0d19630a0@redhat.com> <4deb7e45-e428-d819-aabc-748abe8f7686@redhat.com> <0E421C5A-7EF5-4182-A13B-BF9AEAF90215@comcast.net> <6DA7C7D0-314E-4A5E-8B35-5A8EA2F74CD8@mentor.com> <2b5de569-1efd-f407-49c2-c9fa84cc5315@ubuntu.com> <4964955d-4de1-618c-de41-835ca19f9932@ubuntu.com> <4FBA6B16-460A-4EBB-8809-0883A84ABEB7@mentor.com> <0bf14402-d4e6-5fb0-8a63-479903ed2141@ubuntu.com> <01B885DF-4340-43C6-A784-21326A9CA8CF@comcast.net> <10704c8f-fd72-8d13-17a1-f522e88345b2@ubuntu.com> <31916070-ce2d-423a-e942-33f0b3ebc227@ubuntu.com> <6747724B-4128-4C55-8625-91AA559A0D98@mentor.com> <885027a6-080b-ec6f-89df-533be4132b36@ubuntu.com> <41C15B32-0659-49F2-A918-8A83623E4BF8@codesourcery.com> Cc: Mike Stump , Rainer Orth , Jeff Law , Andrew Haley , GCC Patches , GCJ-patches , Sandra Loosemore From: Matthias Klose Message-ID: <48b62bc3-2870-0113-d165-59057c186e54@ubuntu.com> Date: Mon, 21 Nov 2016 12:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <41C15B32-0659-49F2-A918-8A83623E4BF8@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-q4/txt/msg00028.txt.bz2 On 21.11.2016 11:23, Iain Sandoe wrote: > >> On 20 Nov 2016, at 20:42, Matthias Klose wrote: >> >> On 10.10.2016 09:58, Iain Sandoe wrote: >>> > >>> The point here was to simplify the dependent configury so that it only needs to test something that the configuring user specifies (i.e. if they specify objc-gc, then they need also to specify the place that the gc lib can be found). >> >> So here is the next proposal, I hope the added documentation in install.texi >> makes the usage clear. > > thanks for working on this! > >> >> >> >> 2016-11-19 Matthias Klose >> >> * Makefile.def: Remove reference to boehm-gc target module. >> * configure.ac: Include pkg.m4, check for --with-target-bdw-gc >> options and for the bdw-gc pkg-config module. >> * configure: Regenerate. >> * Makefile.in: Regenerate. > > > +AC_ARG_ENABLE(objc-gc, > +[AS_HELP_STRING([--enable-objc-gc], > + [enable use of Boehm's garbage collector with the > + GNU Objective-C runtime])]) > +AC_ARG_WITH([target-bdw-gc], > +[AS_HELP_STRING([--with-target-bdw-gc=PATHLIST], > + [specify prefix directory for installed bdw-gc package. > + Equivalent to --with-bdw-gc-include=PATH/include > + plus --with-bdw-gc-lib=PATH/lib])]) > > missing “target” in the --with-bdw-gc-* thanks, fixed. >> gcc/ >> >> 2016-11-19 Matthias Klose >> >> * doc/install.texi: Document configure options --enable-objc-gc >> and --with-target-bdw-gc. > > As per Sandra’s comment, should we understand the priority of options is > > --with-target-bdw-gc-* > > which overrides… > > --with-target-bdw-gc= > > which overrides automatic discovery using pkg_config? --with-target-bdw-gc=/opt/bdw-gc,32=/opt/bdw-gc32 sets the include and lib dirs by appending include and lib to the paths. If you have options --with-target-bdw-gc-include= and --with-target-bdw-gc-lib= as well, it overrides the settings done in --with-target-bdw-gc=. This is copied from the setting of the gmp/mpfr options. Any of these options override the automatic discovery using pkg-config. Please suggest a better wording; I thought that was clear enough (and better than the undocumented --enable-libobjc-gc anyway ;) Matthias