* [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9
@ 2008-11-29 2:43 Andrew Pinski
2008-11-29 10:33 ` Andrew Haley
2008-12-18 2:42 ` Andrew Pinski
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Pinski @ 2008-11-29 2:43 UTC (permalink / raw)
To: GCC Patches, Java Patch List, libstdc++
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Hi,
The problem here is after the fix for PR 27880, libstc++ and libgcj
started to have a reference to _Unwind_GetIPInfo for darwin. Darwin 8
and before did not have _Unwind_GetIPInfo in its shared library
version of libgcc (this is a decision made by the target maintainers
and was a deliberate one at that). I fixed it by saying darwin 8 and
before does not have _Unwind_GetIPInfo in GCC_CHECK_UNWIND_GETIPINFO.
OK? Bootstrapped and tested on i386-darwin8.11 with no regressions
(plus it fixes the bootstrap failure I was having).
Thanks,
Andrew Pinski
config/ChangeLog:
* unwind_ipinfo.m4: Darwin before 9 does not have _Unwind_GetIPInfo.
libjava/ChangeLog:
* configure: Regenerate.
libstdc++/ChangeLog:
* configure: Regenerate.
gcc/ChangeLog:
* configure: Regenerate.
[-- Attachment #2: fixdarwin.diff.txt --]
[-- Type: text/plain, Size: 625 bytes --]
Index: config/unwind_ipinfo.m4
===================================================================
--- config/unwind_ipinfo.m4 (revision 142255)
+++ config/unwind_ipinfo.m4 (working copy)
@@ -22,7 +22,13 @@ AC_DEFUN([GCC_CHECK_UNWIND_GETIPINFO], [
*) have_unwind_getipinfo=yes ;;
esac
else
- have_unwind_getipinfo=yes
+ # Darwin before version 9 does not have _Unwind_GetIPInfo.
+ changequote(,)
+ case ${target} in
+ *-*-darwin[1-8].*) have_unwind_getipinfo=no ;;
+ *) have_unwind_getipinfo=yes ;;
+ esac
+ changequote([,])
fi
if test x$have_unwind_getipinfo = xyes; then
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9
2008-11-29 2:43 [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9 Andrew Pinski
@ 2008-11-29 10:33 ` Andrew Haley
2008-12-18 2:42 ` Andrew Pinski
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Haley @ 2008-11-29 10:33 UTC (permalink / raw)
To: Andrew Pinski; +Cc: GCC Patches, Java Patch List, libstdc++
Andrew Pinski wrote:
> The problem here is after the fix for PR 27880, libstc++ and libgcj
> started to have a reference to _Unwind_GetIPInfo for darwin. Darwin 8
> and before did not have _Unwind_GetIPInfo in its shared library
> version of libgcc (this is a decision made by the target maintainers
> and was a deliberate one at that). I fixed it by saying darwin 8 and
> before does not have _Unwind_GetIPInfo in GCC_CHECK_UNWIND_GETIPINFO.
>
> OK? Bootstrapped and tested on i386-darwin8.11 with no regressions
> (plus it fixes the bootstrap failure I was having).
Yes, this is fine for Java. It would be better to have an autoconf check
for _Unwind_GetIPInfo, but this will do.
Andrew.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9
2008-11-29 2:43 [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9 Andrew Pinski
2008-11-29 10:33 ` Andrew Haley
@ 2008-12-18 2:42 ` Andrew Pinski
2008-12-18 10:16 ` Andrew Haley
2008-12-21 22:26 ` Andrew Pinski
1 sibling, 2 replies; 6+ messages in thread
From: Andrew Pinski @ 2008-12-18 2:42 UTC (permalink / raw)
To: GCC Patches, Java Patch List, libstdc++
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Fri, Nov 28, 2008 at 6:43 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> Hi,
> The problem here is after the fix for PR 27880, libstc++ and libgcj
> started to have a reference to _Unwind_GetIPInfo for darwin. Darwin 8
> and before did not have _Unwind_GetIPInfo in its shared library
> version of libgcc (this is a decision made by the target maintainers
> and was a deliberate one at that). I fixed it by saying darwin 8 and
> before does not have _Unwind_GetIPInfo in GCC_CHECK_UNWIND_GETIPINFO.
>
> OK? Bootstrapped and tested on i386-darwin8.11 with no regressions
> (plus it fixes the bootstrap failure I was having).
>
Here is updated patch which takes into the comments to the patch in
the bug report.
OK? Bootstrapped and tested on i386-darwin8.11 with no regressions.
config/ChangeLog:
* unwind_ipinfo.m4: Darwin before 9 does not have _Unwind_GetIPInfo.
libjava/ChangeLog:
* configure: Regenerate.
libstdc++/ChangeLog:
* configure: Regenerate.
gcc/ChangeLog:
* configure: Regenerate.
[-- Attachment #2: fixdarwin.diff.txt --]
[-- Type: text/plain, Size: 620 bytes --]
Index: unwind_ipinfo.m4
===================================================================
--- unwind_ipinfo.m4 (revision 142800)
+++ unwind_ipinfo.m4 (working copy)
@@ -22,7 +22,13 @@ AC_DEFUN([GCC_CHECK_UNWIND_GETIPINFO], [
*) have_unwind_getipinfo=yes ;;
esac
else
- have_unwind_getipinfo=yes
+ # Darwin before version 9 does not have _Unwind_GetIPInfo.
+ changequote(,)
+ case ${target} in
+ *-*-darwin[3-8]|*-*-darwin[3-8].*) have_unwind_getipinfo=no ;;
+ *) have_unwind_getipinfo=yes ;;
+ esac
+ changequote([,])
fi
if test x$have_unwind_getipinfo = xyes; then
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9
2008-12-18 2:42 ` Andrew Pinski
@ 2008-12-18 10:16 ` Andrew Haley
2008-12-19 16:10 ` Steve Ellcey
2008-12-21 22:26 ` Andrew Pinski
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Haley @ 2008-12-18 10:16 UTC (permalink / raw)
To: Andrew Pinski; +Cc: GCC Patches, Java Patch List, libstdc++
Andrew Pinski wrote:
> On Fri, Nov 28, 2008 at 6:43 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>> Hi,
>> The problem here is after the fix for PR 27880, libstc++ and libgcj
>> started to have a reference to _Unwind_GetIPInfo for darwin. Darwin 8
>> and before did not have _Unwind_GetIPInfo in its shared library
>> version of libgcc (this is a decision made by the target maintainers
>> and was a deliberate one at that). I fixed it by saying darwin 8 and
>> before does not have _Unwind_GetIPInfo in GCC_CHECK_UNWIND_GETIPINFO.
>>
>> OK? Bootstrapped and tested on i386-darwin8.11 with no regressions
>> (plus it fixes the bootstrap failure I was having).
>>
>
> Here is updated patch which takes into the comments to the patch in
> the bug report.
>
> OK?
I suppose so, but why on earth are we doing this? Autoconf could
simply test for _Unwind_GetIPInfo.
Andrew.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9
2008-12-18 10:16 ` Andrew Haley
@ 2008-12-19 16:10 ` Steve Ellcey
0 siblings, 0 replies; 6+ messages in thread
From: Steve Ellcey @ 2008-12-19 16:10 UTC (permalink / raw)
To: aph; +Cc: pinskia, gcc-patches, java-patches, libstdc++
> I suppose so, but why on earth are we doing this? Autoconf could
> simply test for _Unwind_GetIPInfo.
>
> Andrew.
See my email at http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00647.html
for why an autconf test was not working on IA64 Linux.
Steve Ellcey
sje@cup.hp.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9
2008-12-18 2:42 ` Andrew Pinski
2008-12-18 10:16 ` Andrew Haley
@ 2008-12-21 22:26 ` Andrew Pinski
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Pinski @ 2008-12-21 22:26 UTC (permalink / raw)
To: GCC Patches, Java Patch List, libstdc++
On Wed, Dec 17, 2008 at 9:41 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Fri, Nov 28, 2008 at 6:43 PM, Andrew Pinski <pinskia@gmail.com> wrote:
>> Hi,
>> The problem here is after the fix for PR 27880, libstc++ and libgcj
>> started to have a reference to _Unwind_GetIPInfo for darwin. Darwin 8
>> and before did not have _Unwind_GetIPInfo in its shared library
>> version of libgcc (this is a decision made by the target maintainers
>> and was a deliberate one at that). I fixed it by saying darwin 8 and
>> before does not have _Unwind_GetIPInfo in GCC_CHECK_UNWIND_GETIPINFO.
>>
>> OK? Bootstrapped and tested on i386-darwin8.11 with no regressions
>> (plus it fixes the bootstrap failure I was having).
>>
>
> Here is updated patch which takes into the comments to the patch in
> the bug report.
>
> OK? Bootstrapped and tested on i386-darwin8.11 with no regressions.
Applied as the approval for the patch was in the bug report.
Thanks,
Andrew Pinski
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-12-21 22:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-29 2:43 [PATCH] Fix PR target/38300 libstdc++ and libgcj contain a reference to _Unwind_GetIPInfo for darwin before 9 Andrew Pinski
2008-11-29 10:33 ` Andrew Haley
2008-12-18 2:42 ` Andrew Pinski
2008-12-18 10:16 ` Andrew Haley
2008-12-19 16:10 ` Steve Ellcey
2008-12-21 22:26 ` Andrew Pinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).