From: Andrew Haley <aph@redhat.com>
To: Dave Korn <dave.korn.cygwin@googlemail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
libffi-discuss@sourceware.org,
Java Patches <java-patches@gcc.gnu.org>,
Rainer Emrich <rainer@emrich-ebersheim.de>
Subject: Re: [PATCH] Fix Cygwin bootstrap, PR40807 and all significant FAILs on win32.
Date: Thu, 23 Jul 2009 10:16:00 -0000 [thread overview]
Message-ID: <4A683873.2020800@redhat.com> (raw)
In-Reply-To: <4A676BBB.3060104@gmail.com>
On 07/22/2009 09:42 PM, Dave Korn wrote:
> Hi all,
>
> While I was looking at the dlmmap/dlmunmap code in closures.c, I started
> looking into testsuite FAILs to see if any of them might be caused by the code
> I had added, and stumbled across a bigger can of worms. The code in win32.S
> doesn't take account of numerous among the FFI_TYPE_xxx return types, leading
> to stack-based garbage being returned, and in one place mishandles the ABI
> convention that the callee should pop the hidden pointer arg for struct return
> types.
>
> Before this patch there were 66 FAILs on libffi HEAD (sourcware) and 20 on
> libffi GCC. After, there are only one or two remaining (depending on GCC
> version), both "test for excess errors" failures related to format-string
> warnings and unrelated to all this. Tested on i686-pc-cygwin; the GCC testing
> only involved bubblestrapping an existing $objdir rather than running a full
> bootstrap, but that should be OK for a target lib.
Did you run the gcj testsuite? If so, what were the results?
Andrew.
next prev parent reply other threads:[~2009-07-23 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-22 19:30 Dave Korn
2009-07-22 20:12 ` [PATCH] Fix Cygwin bootstrap, PR40807 and all significant *libffi* " Dave Korn
2009-07-23 10:16 ` Andrew Haley [this message]
2009-07-23 10:20 ` [PATCH] Fix Cygwin bootstrap, PR40807 and all significant " Dave Korn
2009-07-24 3:08 ` Dave Korn
2009-07-24 9:12 ` Andrew Haley
2009-07-24 10:14 ` Dave Korn
2009-07-23 10:51 ` Timothy Wall
2009-07-23 11:03 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A683873.2020800@redhat.com \
--to=aph@redhat.com \
--cc=dave.korn.cygwin@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=libffi-discuss@sourceware.org \
--cc=rainer@emrich-ebersheim.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).