public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Matthias Klose <doko@ubuntu.com>
To: Dr Andrew John Hughes <gnu_andrew@member.fsf.org>
Cc: Java Patch List <java-patches@gcc.gnu.org>,
	       Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Subject: Re: Classpath Merge (1/3): libgcj-import-20100921
Date: Tue, 05 Oct 2010 08:44:00 -0000	[thread overview]
Message-ID: <4CAAE54B.70906@ubuntu.com> (raw)
In-Reply-To: <AANLkTim7SBaG3oFcDXh-5zkQgbrk6v4RdSrPfMW48u3N@mail.gmail.com>

On 28.09.2010 23:23, Dr Andrew John Hughes wrote:
> Attached is a merge of GNU Classpath into trunk from the tag
> libgcj-import-20100921.  This tag was created against revisions as of
> 2010-06-01 to avoid the whitespace changes on the 3rd.  My intention
> is to post separate whitespace fixes for gcj and then a second merge
> containing changes after this change to Classpath.  This merge however
> contains most of the changes that have lingered in Classpath for a
> long time since the merge for 4.4.
>
> This took longer than expected, mainly due to the presence of
> generated autotools files in the gcj tree which require regeneration
> with specific versions.  gcj seems to have decided to use libtool
> 2.2.7a, which doesn't exist as a release on
> http://ftp.gnu.org/gnu/libtool/ and I ran into conflicts with macros
> from the GNU Classpath import which used the system 2.2.10 install.
> In the end, the solution was to remove the Classpath copy from the m4
> directory, which caused the 2.2.7a macros in
> the top-level config directory to be used.

CCing Ralf for the auto*/libtool stuff. Maybe it's worth documenting the missing 
libtool bits/versions in libjava/HACKING?

> The merge has been tested with both java-maintainer mode and
> non-java-maintainer mode builds, and the Classpath changes have been
> committed to the classpath tree.

I assume that the correct ecj.jar from sourceware.org:/pub/java was used to 
generate the class files.

The generated auto* files are usually not included in the diff for the review.

> Ok for trunk?

Looks okay to me, but I cannot approve it.

   Matthias

  reply	other threads:[~2010-10-05  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 21:23 Dr Andrew John Hughes
2010-10-05  8:44 ` Matthias Klose [this message]
2010-10-05 13:01   ` Dr Andrew John Hughes
2010-10-05 18:04   ` Ralf Wildenhues
2010-10-05 23:45     ` Dr Andrew John Hughes
2010-10-07 12:26 ` Andrew Haley
2010-10-12 17:26   ` Dr Andrew John Hughes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAAE54B.70906@ubuntu.com \
    --to=doko@ubuntu.com \
    --cc=Ralf.Wildenhues@gmx.de \
    --cc=gnu_andrew@member.fsf.org \
    --cc=java-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).