From: Andrew Haley <aph@redhat.com>
To: java-patches@gcc.gnu.org
Subject: Re: [PATCH] move libiconv linkage from libgcj.spec.in to libgcj_la_LDFLAGS
Date: Mon, 20 Jun 2011 09:42:00 -0000 [thread overview]
Message-ID: <4DFF15E6.3060902@redhat.com> (raw)
In-Reply-To: <20110618055143.GA30332@bromo.med.uc.edu>
On 18/06/11 06:51, Jack Howarth wrote:
> The attached patch moves the linkage on $(LDLIBICONV) from libgcj.spec.in to a more correct
> direct linkage on libgcj which contains the unresolved symbols. This change also solves problems
> when a multilib only has libiconv for one of the two architectures (ie building gcc trunk on
> x86_64 fink which lacks a i386 libiconv). Bootstrap and libjava regression tested on x86_64 darwin11.
> Okay for gcc trunk?
> Jack
>
> 2011-06-18 Jack Howarth <howarth@bromo.med.uc.edu>
>
> * libjava/libgcj.spec.in: Don't pass @LDLIBICONV@.
> * libjava/Makefile.am (libgcj_la_LDFLAGS): Pass @LDLIBICONV@.
> * libjava/Makefile.in: Regenerate.
I think so, and this seems obvious, but there must have been some reason
why this was done. It'd be nice to figure out what that was.
Andrew.
prev parent reply other threads:[~2011-06-20 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 5:52 Jack Howarth
2011-06-20 9:42 ` Andrew Haley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF15E6.3060902@redhat.com \
--to=aph@redhat.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).