From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-20312-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 12379 invoked by alias); 29 Jun 2011 11:29:03 -0000
Received: (qmail 12300 invoked by uid 22791); 29 Jun 2011 11:29:02 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jun 2011 11:28:43 +0000
Received: by wyg30 with SMTP id 30so914691wyg.20        for <multiple recipients>; Wed, 29 Jun 2011 04:28:41 -0700 (PDT)
Received: by 10.216.28.1 with SMTP id f1mr627867wea.41.1309346921470;        Wed, 29 Jun 2011 04:28:41 -0700 (PDT)
Received: from yakj.usersys.redhat.com (93-34-199-31.ip51.fastwebnet.it [93.34.199.31])        by mx.google.com with ESMTPS id s47sm591952weq.6.2011.06.29.04.28.39        (version=TLSv1/SSLv3 cipher=OTHER);        Wed, 29 Jun 2011 04:28:40 -0700 (PDT)
Message-ID: <4E0B0C65.3060900@gnu.org>
Date: Wed, 29 Jun 2011 11:29:00 -0000
From: Paolo Bonzini <bonzini@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Mnenhy/0.8.3 Thunderbird/3.1.10
MIME-Version: 1.0
To: "Joseph S. Myers" <joseph@codesourcery.com>
CC: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>, gcc-patches@gcc.gnu.org,  Ralf Wildenhues <Ralf.Wildenhues@gmx.de>, Ian Lance Taylor <iant@google.com>, Steve Ellcey <sje@cup.hp.com>,  Richard Earnshaw <richard.earnshaw@arm.com>, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,  Nick Clifton <nickc@redhat.com>, Douglas Rupp <rupp@gnat.com>, Tristan Gingold <gingold@adacore.com>,  Mike Stump <mikestump@comcast.net>, Kaz Kojima <kkojima@gcc.gnu.org>, David Edelsohn <dje.gcc@gmail.com>,  Sterling Augustine <augustine.sterling@gmail.com>, Arnaud Charlet <charlet@adacore.com>, java-patches@gcc.gnu.org,  Nicola Pero <nicola.pero@meta-innovation.com>, libstdc++@gcc.gnu.org, Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: [build] Move unwinder to toplevel libgcc
References: <yddfwn4pu5u.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <4E0AEEF0.7080406@gnu.org> <Pine.LNX.4.64.1106291037290.22294@digraph.polyomino.org.uk>
In-Reply-To: <Pine.LNX.4.64.1106291037290.22294@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2011-q2/txt/msg00089.txt.bz2

On 06/29/2011 12:41 PM, Joseph S. Myers wrote:
> On Wed, 29 Jun 2011, Paolo Bonzini wrote:
>
>> On 06/20/2011 02:24 PM, Rainer Orth wrote:
>>> * The only unwinder-related macro I haven't moved is
>>>     LIBGCC2_UNWIND_ATTRIBUTE.  It is only defined gcc/config/mips/mips.h.
>>>     I suppose we would need a libgcc equivalent of tm.h for that,
>>>     something I didn't want to attack at this point.
>>
>> Something like the attached?
>
> This patch appears to create a *second* file called libgcc_tm.h, so there
> is one created in gcc/ and one in libgcc/, which seems incredibly
> confusing.  By all means move the libgcc_tm.h logic to libgcc/ (though
> tm.h will need to continue to include libgcc_tm.h for the target, until
> the transition away from tm.h target macros in target code is complete and
> code includes libgcc_tm.h directly instead), but don't have two headers
> with the same name in different build directories.

Yes, the patch was not complete and only meant to be the plumbing for 
what you describe.

I think Rainer missed the existence of libgcc_tm_file. :)

Paolo