From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28110 invoked by alias); 7 Jul 2011 16:51:22 -0000 Received: (qmail 28094 invoked by uid 22791); 7 Jul 2011 16:51:21 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,TW_IB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail3.caviumnetworks.com (HELO mail3.caviumnetworks.com) (12.108.191.235) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jul 2011 16:51:03 +0000 Received: from caexch01.caveonetworks.com (Not Verified[192.168.16.9]) by mail3.caviumnetworks.com with MailMarshal (v6,7,2,8378) id ; Thu, 07 Jul 2011 09:52:11 -0700 Received: from caexch01.caveonetworks.com ([192.168.16.9]) by caexch01.caveonetworks.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 7 Jul 2011 09:51:03 -0700 Received: from dd1.caveonetworks.com ([12.108.191.236]) by caexch01.caveonetworks.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 7 Jul 2011 09:51:03 -0700 Message-ID: <4E15E3F6.3050502@cavium.com> Date: Thu, 07 Jul 2011 16:51:00 -0000 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Matthias Klose CC: GCJ-patches , GCC Patches , Andrew Haley , David Daney Subject: Re: [patch] Disable static build for libjava References: <4E15DE84.5030809@ubuntu.com> In-Reply-To: <4E15DE84.5030809@ubuntu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q3/txt/msg00008.txt.bz2 On 07/07/2011 09:27 AM, Matthias Klose wrote: > As discussed at the Google GCC gathering, disable the build of static libraries > in libjava, which should cut the build time of libjava by 50%. The static > libjava build isn't useful out of the box, and I don't see it packaged by Linux > distributions either. > > The AC_PROG_LIBTOOL check is needed to get access to the enable_shared macro. > I'm unsure about the check in the switch construct. Taken from libtool.m4, and > determining the value of enable_shared_with_static_runtimes. > > Ok for the trunk? > > 2011-07-07 Matthias Klose > > * Makefile.def (target_modules/libjava): Pass > $(libjava_disable_static). > * configure.ac: Check for libtool, pass --disable-static > in libjava_disable_static. > * Makefile.in: Regenerate. > * configure: Likewise. > My autoconf fu is not what it used to be. It is fine if static libraries are disabled by default, but it should be possible to enable them from the configure command line. It is unclear to me if this patch does that. Also I would like to go on record as disagreeing with the statement that 'static libjava build isn't useful out of the box' David Daney > Index: Makefile.def > =================================================================== > --- Makefile.def (revision 175963) > +++ Makefile.def (working copy) > @@ -132,7 +132,8 @@ > target_modules = { module= winsup; }; > target_modules = { module= libgloss; no_check=true; }; > target_modules = { module= libffi; }; > -target_modules = { module= libjava; raw_cxx=true; }; > +target_modules = { module= libjava; raw_cxx=true; > + extra_configure_flags="$(libjava_disable_static)"; }; > target_modules = { module= zlib; }; > target_modules = { module= boehm-gc; }; > target_modules = { module= rda; }; > Index: configure.ac > =================================================================== > --- configure.ac (revision 175963) > +++ configure.ac (working copy) > @@ -443,6 +443,16 @@ > ;; > esac > > +AC_PROG_LIBTOOL > +if test x$enable_shared = xyes ; then > + case $host_cpu in > + cygwin* | mingw* | pw32* | cegcc*) > + ;; > + *) > + libjava_disable_static=--disable-static > + esac > +fi > +AC_SUBST(libjava_disable_static) > > # Disable libmudflap on some systems. > if test x$enable_libmudflap = x ; then > >