From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10061 invoked by alias); 7 Jul 2011 17:56:47 -0000 Received: (qmail 10053 invoked by uid 22791); 7 Jul 2011 17:56:47 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_IB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jul 2011 17:56:31 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p67HuUaP013872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Jul 2011 13:56:30 -0400 Received: from zebedee.pink (ovpn-113-63.phx2.redhat.com [10.3.113.63]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p67HuTn8005358; Thu, 7 Jul 2011 13:56:29 -0400 Message-ID: <4E15F34D.7050800@redhat.com> Date: Thu, 07 Jul 2011 17:56:00 -0000 From: Andrew Haley User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 MIME-Version: 1.0 To: java-patches@gcc.gnu.org Subject: Re: [patch] Disable static build for libjava References: <4E15DE84.5030809@ubuntu.com> <4E15E3F6.3050502@cavium.com> <4E15E56E.4070209@ubuntu.com> <4E15E6AF.4050508@cavium.com> In-Reply-To: <4E15E6AF.4050508@cavium.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q3/txt/msg00012.txt.bz2 On 07/07/11 18:02, David Daney wrote: > On 07/07/2011 09:57 AM, Matthias Klose wrote: >> On 07/07/2011 06:51 PM, David Daney wrote: >>> On 07/07/2011 09:27 AM, Matthias Klose wrote: >>>> As discussed at the Google GCC gathering, disable the build of static libraries >>>> in libjava, which should cut the build time of libjava by 50%. The static >>>> libjava build isn't useful out of the box, and I don't see it packaged by Linux >>>> distributions either. >>>> >>>> The AC_PROG_LIBTOOL check is needed to get access to the enable_shared macro. >>>> I'm unsure about the check in the switch construct. Taken from libtool.m4, and >>>> determining the value of enable_shared_with_static_runtimes. >>>> >>>> Ok for the trunk? >>>> >>>> 2011-07-07 Matthias Klose >>>> >>>> * Makefile.def (target_modules/libjava): Pass >>>> $(libjava_disable_static). >>>> * configure.ac: Check for libtool, pass --disable-static >>>> in libjava_disable_static. >>>> * Makefile.in: Regenerate. >>>> * configure: Likewise. >>>> >>> >>> My autoconf fu is not what it used to be. It is fine if static libraries are >>> disabled by default, but it should be possible to enable them from the configure >>> command line. It is unclear to me if this patch does that. >> >> no. I assume an extra option --enable-static-libjava would be needed. > > Not being a libjava maintainer, I cannot force you to add something like > that as part of the patch, but I think it would be a good idea. I think so. Andrew.