From: Andrew Haley <aph@redhat.com>
To: java-patches@gcc.gnu.org
Subject: Re: [PATCH][JAVA] Build a correct tree for rewritten method invocations
Date: Wed, 03 Aug 2011 08:41:00 -0000 [thread overview]
Message-ID: <4E390997.2040603@redhat.com> (raw)
In-Reply-To: <1312314963-5829-1-git-send-email-peter@pcc.me.uk>
On 08/02/2011 08:56 PM, Peter Collingbourne wrote:
> The Java frontend currently produces an incorrectly typed tree if
> a method call is rewritten. Specifically, the callee operand is a
> NOP_EXPR casting the address of the target method to the original
> method type. This patch causes the NOP_EXPR cast to use the type of
> the target method instead.
>
> The bug is exposed by dragonegg which requires the callee type to be
> correct.
>
> libjava tested, x86_64-unknown-linux-gnu.
>
> 2011-08-02 Peter Collingbourne <peter@pcc.me.uk>
>
> * expr.c (expand_invoke) Use the type of the method rewrite target.
Yes, I see. This looks OK.
Two questions:
Did you run the libjava test suite?
Do you have commit access?
Andrew.
next prev parent reply other threads:[~2011-08-03 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 19:56 Peter Collingbourne
2011-08-03 8:41 ` Andrew Haley [this message]
2011-08-03 20:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E390997.2040603@redhat.com \
--to=aph@redhat.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).