From: Andrew Haley <aph@redhat.com>
To: java-patches@gcc.gnu.org
Subject: Re: Merge GNU Classpath 0.99 into gcj trunk
Date: Wed, 21 Mar 2012 18:22:00 -0000 [thread overview]
Message-ID: <4F6A1C68.3070902@redhat.com> (raw)
In-Reply-To: <74de1c16-5780-497b-8b22-0c60f3b56d3f@zmail17.collab.prod.int.phx2.redhat.com>
On 03/21/2012 05:38 PM, Andrew Hughes wrote:
> ----- Original Message -----
>> On 03/16/2012 03:12 PM, Dr Andrew John Hughes wrote:
>>> Ok for trunk?
>>
>> There's a lot of generated stuff in that patch, which makes the
>> patch very hard to review. Please include only source files.
>>
>> So, no generated headers, no configure files, no ltmain, etc,
>
> Well this is a merge, so I would have thought the main thing to check
> was the build changes that resulted, rather than the source file changes
> which have already been reviewed and committed to GNU Classpath. Plus,
> the original patch matches what will be checked in.
>
> But anyway, attached are the source file changes, which are all already
> in GNU Classpath.
Thanks. The patch is OK.
Andrew.
prev parent reply other threads:[~2012-03-21 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 15:14 Dr Andrew John Hughes
2012-03-21 15:18 ` Andrew Haley
2012-03-21 17:38 ` Andrew Hughes
2012-03-21 18:22 ` Andrew Haley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A1C68.3070902@redhat.com \
--to=aph@redhat.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).