From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3346 invoked by alias); 6 Apr 2012 20:30:10 -0000 Received: (qmail 3315 invoked by uid 22791); 6 Apr 2012 20:30:08 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,TW_BF X-Spam-Check-By: sourceware.org Received: from youngberry.canonical.com (HELO youngberry.canonical.com) (91.189.89.112) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Apr 2012 20:29:45 +0000 Received: from dslb-088-073-069-072.pools.arcor-ip.net ([88.73.69.72] helo=[192.168.42.210]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1SGFmx-0007Lr-TU; Fri, 06 Apr 2012 20:29:43 +0000 Message-ID: <4F7F5233.7060508@ubuntu.com> Date: Fri, 06 Apr 2012 20:30:00 -0000 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120402 Thunderbird/11.0.1 MIME-Version: 1.0 To: Anthony Green CC: libffi-discuss@sourceware.org, David Gilbert , GCJ-patches Subject: Re: Please help test libffi 3.0.11-rc3 References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------030608010102090201010107" X-IsSubscribed: yes Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2012-q2/txt/msg00005.txt.bz2 This is a multi-part message in MIME format. --------------030608010102090201010107 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1064 [ CC'ing David although I don't know if his Linaro address will still work] On 06.04.2012 14:28, Anthony Green wrote: > I've uploaded release candidate 3 for testing here: > ftp://sourceware.org/pub/libffi/libffi-3.0.11-rc3.tar.gz > > Please test it on whatever systems you have at your disposal, and > update the testing wiki here: > http://www.moxielogic.org/wiki/index.php/Libffi_3.0.11 > > I'd like to make a release within a week. > > Here's what the README says about 3.0.11... > > Add support for variadic functions (ffi_prep_cif_var). > Add Linux/x32 support. > Add thiscall, fastcall and MSVC cdecl support on Windows. > Add Amiga and newer MacOS support. > Fix Octeon and MC68881 support. > Add m68k FreeMiNT support. > Fix code pessimizations. > Lots of build fixes. > > Let me know if I should add anything else. I see that some of the armhf-variadic patches are not applied, attached. Please could you confirm if dropping these changes is deliberate? Thanks, Matthias --------------030608010102090201010107 Content-Type: text/plain; charset=UTF-8; name="armhf-varargs.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="armhf-varargs.diff" Content-length: 1565 --- libffi-3.0.11~rc1.orig/testsuite/libffi.call/cls_double_va.c +++ libffi-3.0.11~rc1/testsuite/libffi.call/cls_double_va.c @@ -7,7 +7,6 @@ /* { dg-do run { xfail strongarm*-*-* xscale*-*-* } } */ /* { dg-output "" { xfail avr32*-*-* } } */ /* { dg-output "" { xfail mips-sgi-irix6* } } PR libffi/46660 */ -/* { dg-skip-if "" arm*-*-* { "-mfloat-abi=hard" } { "" } } */ #include "ffitest.h" --- libffi-3.0.11~rc1.orig/testsuite/libffi.call/cls_longdouble_va.c +++ libffi-3.0.11~rc1/testsuite/libffi.call/cls_longdouble_va.c @@ -7,7 +7,6 @@ /* { dg-do run { xfail strongarm*-*-* xscale*-*-* } } */ /* { dg-output "" { xfail avr32*-*-* x86_64-*-mingw* } } */ /* { dg-output "" { xfail mips-sgi-irix6* } } PR libffi/46660 */ -/* { dg-skip-if "" arm*-*-* { "-mfloat-abi=hard" } { "" } } */ #include "ffitest.h" --- libffi-3.0.11~rc1.orig/src/arm/ffi.c +++ libffi-3.0.11~rc1/src/arm/ffi.c @@ -189,6 +189,18 @@ ffi_status ffi_prep_cif_machdep(ffi_cif return FFI_OK; } +/* Perform machine dependent cif processing for variadic calls */ +ffi_status ffi_prep_cif_machdep_var(ffi_cif *cif, + unsigned int nfixedargs, + unsigned int ntotalargs) +{ + /* VFP variadic calls actually use the SYSV ABI */ + if (cif->abi == FFI_VFP) + cif->abi = FFI_SYSV; + + return ffi_prep_cif_machdep(cif); +} + /* Prototypes for assembly functions, in sysv.S */ extern void ffi_call_SYSV (void (*fn)(void), extended_cif *, unsigned, unsigned, unsigned *); extern void ffi_call_VFP (void (*fn)(void), extended_cif *, unsigned, unsigned, unsigned *); --------------030608010102090201010107--