From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12230 invoked by alias); 26 Mar 2013 20:04:08 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 12197 invoked by uid 89); 26 Mar 2013 20:04:01 -0000 X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,TW_BF autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from youngberry.canonical.com (HELO youngberry.canonical.com) (91.189.89.112) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 26 Mar 2013 20:03:57 +0000 Received: from dslb-088-073-106-090.pools.arcor-ip.net ([88.73.106.90] helo=[192.168.42.216]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1UKa66-0003P7-2Y; Tue, 26 Mar 2013 20:03:54 +0000 Message-ID: <5151FF27.6040606@ubuntu.com> Date: Tue, 26 Mar 2013 20:04:00 -0000 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Andrew Haley , Tom Tromey , Ian Lance Taylor CC: GCC Patches , GCJ-patches , "libffi-discuss@sourceware.org" Subject: [ping] Re: [patch] [libffi] do not install libffi library, headers and documentation References: <511A35DC.7060207@ubuntu.com> <51225EBE.1050509@ubuntu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-q1/txt/msg00026.txt.bz2 [ping, adding the GCJ and Go maintainers] proposed patch at http://gcc.gnu.org/ml/gcc-patches/2013-02/msg00853.html Am 19.02.2013 10:13, schrieb Richard Biener: > On Mon, Feb 18, 2013 at 6:02 PM, Matthias Klose wrote: >> Am 12.02.2013 13:45, schrieb Richard Biener: >>> On Tue, Feb 12, 2013 at 1:44 PM, Richard Biener >>> wrote: >>>> On Tue, Feb 12, 2013 at 1:30 PM, Matthias Klose wrote: >>>>> The libffi library, headers and documentation are still installed, although >>>>> libffi provides separate releases for a long time. So do not install these >>>>> anymore as part of a GCC install. Tested with a build and an install with go >>>>> and java enabled (both using libffi_convenience). Ok for the trunk? >>>> >>>> openSUSE is using the GCC provided libffi, so no, this is not ok (not at this >>>> stage anyway). Also proper not-installing libffi would work by disabling >>>> the maybe-install-target-libffi at the toplevel, not changing libffi makfiles >>>> (which are supposed to be imported from upstream, no?) >>> >>> Thus, add no_install= true; to the libffi target module >> >> updated patch attached, checked with a make install that no ffi headers and >> libraries are installed. If not ok for 4.8, ok for 4.9 when it opens? > > I'm fine with that variant but I'd like to see another ok. No preference as to > whether to target 4.8 or 4.9. > > Richard. > >> Matthias >>