[patch] include the %I spec when building the object file for the main function

[patch] include the %I spec when building the object file for the main function

[Matthias Klose]

[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]

I recently did see a libjava build failure with glibc-2.17, of the form:

libtool: link:
/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/./gcc/gcj
-B/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/arm-linux-gnueabi/libjava/
-B/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/./gcc/
-B/usr/arm-linux-gnueabi/bin/ -B/usr/arm-linux-gnueabi/lib/ -isystem
/usr/arm-linux-gnueabi/include -isystem /usr/arm-linux-gnueabi/sys-include -g
-O2 -o .libs/jv-convert --main=gnu.gcj.convert.Convert -shared-libgcc
-Wl,--no-merge-exidx-entries
-L/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/arm-linux-gnueabi/libjava/.libs
-L/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/arm-linux-gnueabi/libjava
-L/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/arm-linux-gnueabi/libjava/../libstdc++-v3/src/.libs
/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/arm-linux-gnueabi/libjava/../libstdc++-v3/src/.libs/libstdc++.so
./.libs/libgcj.so
/build/buildd-gcj-4.8_4.8.0-2-armel-YVuMIc/gcj-4.8-4.8.0/build/arm-linux-gnueabi/libstdc++-v3/src/.libs/libstdc++.so
-lm -lpthread -lrt -ldl -lz -Wl,-rpath -Wl,/usr/lib/arm-linux-gnueabi
In file included from <command-line>:0:0:
/usr/include/stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file or
directory
 #include <bits/predefs.h>
                          ^
compilation terminated.
make[5]: *** [jv-convert] Error 1

The inclusion of stdc-predef.h is new in 4.8, the bits/predefs.h is not found in
my case, because this header is on an include path, which is only added when cc1
is passed the -imultiarch <tuple> option.  The solution for me is to add the %I
spec, when calling cc1 to build the main function.

Ok for the trunk, and for 4.8 after the 4.8.1 release?

  Matthias

[-- Attachment #2: jvspec.diff --]
[-- Type: text/plain, Size: 416 bytes --]


	* jvspec.c (jvgenmain_spec): Add %I to cc1 call.

--- a/src/gcc/java/jvspec.c
+++ b/src/gcc/java/jvspec.c
@@ -59,7 +59,7 @@
   "jvgenmain %{findirect-dispatch} %{D*} %b %m.i |\n\
    cc1 %m.i %1 \
 		   %{!Q:-quiet} -dumpbase %b.c %{d*} %{m*}\
-		   %{g*} %{O*} \
+		   %{g*} %{O*} %I \
 		   %{v:-version} %{pg:-p} %{p}\
 		   %<fbounds-check %<fno-bounds-check\
 		   %<fassume-compiled* %<fno-assume-compiled*\

Re: [patch] include the %I spec when building the object file for the main function

[Andrew Haley]

On 05/21/2013 08:23 AM, Matthias Klose wrote:
> The inclusion of stdc-predef.h is new in 4.8, the bits/predefs.h is not found in
> my case, because this header is on an include path, which is only added when cc1
> is passed the -imultiarch <tuple> option.  The solution for me is to add the %I
> spec, when calling cc1 to build the main function.
> 
> Ok for the trunk, and for 4.8 after the 4.8.1 release?

This is slighty baffling.  GCC is auto-including stdc-predef.h, but the
path info isn't sufficient?  And why does this affect gcj?

Andrew.

Re: [patch] include the %I spec when building the object file for the main function

[Matthias Klose]

Am 21.05.2013 10:26, schrieb Andrew Haley:
> On 05/21/2013 08:23 AM, Matthias Klose wrote:
>> The inclusion of stdc-predef.h is new in 4.8, the bits/predefs.h is not found in
>> my case, because this header is on an include path, which is only added when cc1
>> is passed the -imultiarch <tuple> option.  The solution for me is to add the %I
>> spec, when calling cc1 to build the main function.
>>
>> Ok for the trunk, and for 4.8 after the 4.8.1 release?
> 
> This is slighty baffling.  GCC is auto-including stdc-predef.h, but the
> path info isn't sufficient?

"because this header is on an include path, which is only added when cc1 is
passed the -imultiarch <tuple> option."

sorry, but I don't know what to add else here to explai the issue.

> And why does this affect gcj?

"when calling cc1 to build the main function". So it does have it's own
invocation of cc1, and doesn't use any specs how to call cc1, which is used for
other C files.

  Matthias

Re: [patch] include the %I spec when building the object file for the main function

[Andrew Haley]

On 05/21/2013 11:49 AM, Matthias Klose wrote:
> Am 21.05.2013 10:26, schrieb Andrew Haley:
>> On 05/21/2013 08:23 AM, Matthias Klose wrote:
>>> The inclusion of stdc-predef.h is new in 4.8, the bits/predefs.h is not found in
>>> my case, because this header is on an include path, which is only added when cc1
>>> is passed the -imultiarch <tuple> option.  The solution for me is to add the %I
>>> spec, when calling cc1 to build the main function.
>>>
>>> Ok for the trunk, and for 4.8 after the 4.8.1 release?
>>
>> This is slighty baffling.  GCC is auto-including stdc-predef.h, but the
>> path info isn't sufficient?
> 
> "because this header is on an include path, which is only added when cc1 is
> passed the -imultiarch <tuple> option."
> 
> sorry, but I don't know what to add else here to explai the issue.
> 
>> And why does this affect gcj?
> 
> "when calling cc1 to build the main function". So it does have it's own
> invocation of cc1, and doesn't use any specs how to call cc1, which is used for
> other C files.

Yes, but what I didn't understand was "why has this changed now?"

Andrew.