From: Matthias Klose <doko@ubuntu.com>
To: GCJ-patches <java-patches@gcc.gnu.org>
Subject: [patch] Link the dummy libgcj_bc shared library with --no-as-needed
Date: Wed, 04 Sep 2013 10:05:00 -0000 [thread overview]
Message-ID: <52270600.8010008@ubuntu.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
When building a compiler which passes --no-as-needed by default to the linker,
libgcj_bc.so ends up without a DTNEEDED entry for libgcj, because no symbols in
libgcj are required to resolve symbols in libgcj_bc. This causes about 500 test
cases to fail. Solved by explicitly passing -Wl,--no-as-needed. Is this ok for
upstream? It's not needed, but doesn't hurt either.
Matthias
[-- Attachment #2: gcc-as-needed.diff --]
[-- Type: text/plain, Size: 513 bytes --]
* Makefile.am (libgcj_bc.la): Link using -Wl,--no-as-needed.
* Makefile.in: Regenerate.
--- a/src/libjava/Makefile.am
+++ b/src/libjava/Makefile.am
@@ -625,7 +625,7 @@
rm .libs/libgcj_bc.so; \
mv .libs/libgcj_bc.so.1.0.0 .libs/libgcj_bc.so; \
$(libgcj_bc_dummy_LINK) -xc /dev/null -Wl,-soname,libgcj_bc.so.1 \
- -o .libs/libgcj_bc.so.1.0.0 -lgcj || exit; \
+ -o .libs/libgcj_bc.so.1.0.0 -Wl,--no-as-needed -lgcj || exit; \
rm .libs/libgcj_bc.so.1; \
$(LN_S) libgcj_bc.so.1.0.0 .libs/libgcj_bc.so.1
next reply other threads:[~2013-09-04 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 10:05 Matthias Klose [this message]
2013-09-04 10:21 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52270600.8010008@ubuntu.com \
--to=doko@ubuntu.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).