* [patch] boehm-gc: link libgcjgc with -ldl
@ 2013-09-04 10:00 Matthias Klose
2013-09-04 10:21 ` Andrew Haley
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Klose @ 2013-09-04 10:00 UTC (permalink / raw)
To: GCC Patches, GCJ-patches
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
The boehm-gc tests currently fail to build with a linker with
--no-copy-dt-needed-entries as the default. dlopen is referenced in the libgcjgc
library itself, so link it with -ldl. The macro name EXTRA_TEST_LIBS is a bit
unfortunate now, but it is the right way to find the library name, as done for
the tests itself.
Ok for the trunk and the 4.8 branch?
Matthias
[-- Attachment #2: boehm-gc-link.diff --]
[-- Type: text/plain, Size: 576 bytes --]
* Makefile.am (libgcjgc_la_LIBADD): Add EXTRA_TEST_LIBS.
* Makefile.in: Regenerate.
--- a/src/boehm-gc/Makefile.am
+++ a/src/boehm-gc/Makefile.am
@@ -35,7 +35,7 @@
# Include THREADLIBS here to ensure that the correct versions of
# linuxthread semaphore functions get linked:
-libgcjgc_la_LIBADD = $(addobjs) $(THREADLIBS)
+libgcjgc_la_LIBADD = $(addobjs) $(THREADLIBS) $(EXTRA_TEST_LIBS)
libgcjgc_la_DEPENDENCIES = $(addobjs)
libgcjgc_la_LDFLAGS = $(extra_ldflags_libgc) -version-info 1:2:0 -rpath $(toolexeclibdir)
libgcjgc_la_LINK = $(LINK) $(libgcjgc_la_LDFLAGS)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] boehm-gc: link libgcjgc with -ldl
2013-09-04 10:00 [patch] boehm-gc: link libgcjgc with -ldl Matthias Klose
@ 2013-09-04 10:21 ` Andrew Haley
2013-09-04 10:24 ` Matthias Klose
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Haley @ 2013-09-04 10:21 UTC (permalink / raw)
To: Matthias Klose; +Cc: GCC Patches, GCJ-patches
On 09/04/2013 11:00 AM, Matthias Klose wrote:
> The boehm-gc tests currently fail to build with a linker with
> --no-copy-dt-needed-entries as the default.
Hmm, isn't that a bug in the linker?
Andrew.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] boehm-gc: link libgcjgc with -ldl
2013-09-04 10:21 ` Andrew Haley
@ 2013-09-04 10:24 ` Matthias Klose
2013-09-04 10:25 ` Andrew Haley
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Klose @ 2013-09-04 10:24 UTC (permalink / raw)
To: Andrew Haley; +Cc: GCC Patches, GCJ-patches
Am 04.09.2013 12:21, schrieb Andrew Haley:
> On 09/04/2013 11:00 AM, Matthias Klose wrote:
>> The boehm-gc tests currently fail to build with a linker with
>> --no-copy-dt-needed-entries as the default.
>
> Hmm, isn't that a bug in the linker?
No, it's the default in gold and in the bfd linker since 2.23.
Matthias
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] boehm-gc: link libgcjgc with -ldl
2013-09-04 10:24 ` Matthias Klose
@ 2013-09-04 10:25 ` Andrew Haley
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Haley @ 2013-09-04 10:25 UTC (permalink / raw)
To: Matthias Klose; +Cc: GCC Patches, GCJ-patches
On 09/04/2013 11:24 AM, Matthias Klose wrote:
> Am 04.09.2013 12:21, schrieb Andrew Haley:
>> On 09/04/2013 11:00 AM, Matthias Klose wrote:
>>> The boehm-gc tests currently fail to build with a linker with
>>> --no-copy-dt-needed-entries as the default.
>>
>> Hmm, isn't that a bug in the linker?
>
> No, it's the default in gold and in the bfd linker since 2.23.
Oh, right. I wonder how many other things this will break. OK.
Andrew.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-04 10:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-04 10:00 [patch] boehm-gc: link libgcjgc with -ldl Matthias Klose
2013-09-04 10:21 ` Andrew Haley
2013-09-04 10:24 ` Matthias Klose
2013-09-04 10:25 ` Andrew Haley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).