From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12824 invoked by alias); 10 Dec 2013 15:51:42 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 12810 invoked by uid 89); 10 Dec 2013 15:51:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: einhorn.in-berlin.de Received: from Unknown (HELO einhorn.in-berlin.de) (192.109.42.8) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 10 Dec 2013 15:51:40 +0000 X-Envelope-From: doko@ubuntu.com Received: from [192.168.42.220] (dslb-088-073-125-221.pools.arcor-ip.net [88.73.125.221]) (authenticated bits=0) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id rBAFpT0w018128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 10 Dec 2013 16:51:29 +0100 Message-ID: <52A7386F.6000209@ubuntu.com> Date: Tue, 10 Dec 2013 15:51:00 -0000 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Andrew Haley CC: Jon VanAlten , GCJ-patches , Tom Tromey Subject: Re: ping: Re: [patch] update ecj to ecj-3.8.2/4.2.2 References: <516BD4B9.8040101@ubuntu.com> <51C2F7FA.9000101@ubuntu.com> <1465929016.3776725.1372274627134.JavaMail.root@redhat.com> <51D29F0E.2000400@ubuntu.com> <1437863721.2322487.1372791878657.JavaMail.root@redhat.com> In-Reply-To: <1437863721.2322487.1372791878657.JavaMail.root@redhat.com> Content-Type: multipart/mixed; boundary="------------050603020409050706070607" X-IsSubscribed: yes X-SW-Source: 2013-q4/txt/msg00008.txt.bz2 This is a multi-part message in MIME format. --------------050603020409050706070607 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 3283 Am 02.07.2013 21:04, schrieb Jon VanAlten: > > > ----- Original Message ----- >> From: "Matthias Klose" >> To: "Jon VanAlten" >> Cc: "GCJ-patches" , "Tom Tromey" , "Andrew Haley" >> Sent: Tuesday, July 2, 2013 3:36:14 AM >> Subject: Re: ping: Re: [patch] update ecj to ecj-3.8.2/4.2.2 >> >> On 06/26/13 21:23, Jon VanAlten wrote: >>> >>> checkout: >>> - cvs -d $(cvsroot) co -r$(TAG) org.eclipse.jdt.core >>> +# git clone -b R3_8_maintenance >>> git://git.eclipse.org/gitroot/jdt/eclipse.jdt.core.git >>> +# wget >>> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/snapshot/$(TAG).tar.gz >>> + tar xf $(TAG).tar.gz >>> >>> So "checkout" target no longer does a checkout... seems a bit off. Is >>> the commented git clone line left over from doing some of this before >>> the official tag existed? Might want to drop that, and consider >>> renaming the target to reflect its new behaviour. >> >> sure, I can rename that. any suggestion? The purpose is to make it clear >> where >> the source do come from. > > If my reading of this is correct, this make target now does some moving > about of things that are already checked out into the local filesystem. > My suggestion would be to call it "prepare-sources" or just "prepare". > >> >>> + tar -c -f - -C $(TAG)/org.eclipse.jdt.core/compiler org \ >>> + | tar -x -f - -C org.eclipse.jdt.core/ >>> >>> Am I missing something or is this equivalent and simpler: >>> >>> + mv $(TAG)/org.eclipse.jdt.core/compiler/org org.eclipse.jdt.core/ >>> >>> + tar -c -f - -C $(TAG)/org.eclipse.jdt.core/batch org \ >>> + | tar -x -f - -C org.eclipse.jdt.core/ >>> >>> Ditto. >> >> yes, not having to run the checkout / pull from the web again. >> > > Right, so doing it as "cp -ar" instead of a "mv" would accomplish same? > >>> As for the GCCMain portion of the change, yes it looks both necessary >>> and correct. We do same in Fedora package (once again sorry it didn't >>> get posted upstream due to my ignorance), and it would be nice to drop >>> the patch once this is in a release. >> >> yes, having this upstream would be appreciated. >> >> So besides the style how to do fetch the sources, this looks ok? >> > > Yep. > >> Is there another newer released ecj version which should be used instead? >> > > Let's check the authoritative source[1] for that. It does seem as though > they've done their 4.3 release, the sources for just ecj can be found > under JDT Core Batch Compiler at [2]. News[3] does mention a few compiler > improvements, but I might suggest to first push update to 3.8 and then > update to latest in separate commit (so anyone else who consumes this can > choose the version they prefer). > > cheers, > jon > > [1] http://download.eclipse.org/eclipse/downloads/ > [2] http://download.eclipse.org/eclipse/downloads/drops4/R-4.3-201306052000/ > [3] http://download.eclipse.org/eclipse/downloads/drops4/R-4.3-201306052000/news/eclipse-news-part2.html > now updated to build from the 4.3.1 release (ecj itself identified as 3.9.0). Renamed the download target into prepare, and removed the comment. Test built libjava with --enable-maintainer-mode. No regressions. Ok to checkin? Matthias --------------050603020409050706070607 Content-Type: text/plain; charset=UTF-8; name="eclipse-gcj.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="eclipse-gcj.diff" Content-length: 5470 MjAxMy0xMi0xMCAgTWF0dGhpYXMgS2xvc2UgIDxkb2tvQHVidW50dS5jb20+ CgoJKiBNYWtlZmlsZSAoVEFHKTogU2V0IHRvIFI0XzNfMS4gKGN2c3Jvb3Qs IGxvZ2luKTogUmVtb3ZlLAoJKGNoZWNrb3V0KTogUmVuYW1lIHRvIHByZXBh cmUuCgkocHJlcGFyZSk6IERvd25sb2FkIGZyb20gZ2l0IHJlcG9zaXRvcnku CgkoY29tcGlsZSk6IENvbXBpbGUgZm9yIDEuNSwgY2F0Y2ggZXJyb3JzIGNv cHlpbmcgcmVzb3VyY2UgZmlsZXMsCglkb24ndCBpbmNsdWRlIHRoZSBNRVRB LUlORiBmaWxlLgoJKiBvcmcvZWNsaXBzZS9qZHQvaW50ZXJuYWwvY29tcGls ZXIvYmF0Y2gvR0NDTWFpbi5qYXZhOiBBZG9wdCB0bwoJbmV3IEFQSS4KCQog CkluZGV4OiBNYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3JodWcvZWNsaXBzZS1nY2ovTWFrZWZpbGUsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMTAKZGlmZiAtdSAtcjEuMTAgTWFrZWZpbGUKLS0t IE1ha2VmaWxlCTI4IFNlcCAyMDA5IDE3OjM4OjMxIC0wMDAwCTEuMTAKKysr IE1ha2VmaWxlCTEwIERlYyAyMDEzIDE1OjQ3OjM1IC0wMDAwCkBAIC0xLDQg KzEsNCBAQAotVEFHID0gUjNfNV8xCitUQUcgPSBSNF8zXzEKIAogY3Zzcm9v dCA9IDpwc2VydmVyOmFub255bW91c0BkZXYuZWNsaXBzZS5vcmc6L2N2c3Jv b3QvZWNsaXBzZQogCkBAIC0xMSwxMyArMTEsMjYgQEAKIAkkKE1BS0UpIGNv bXBpbGUKIAkkKE1BS0UpIGVjai5qYXIgZWNqLXNvdXJjZS50YXIuYnoyCiAK LWxvZ2luOgotCWN2cyAtZCAkKGN2c3Jvb3QpIGxvZ2luCitwcmVwYXJlOgor CXdnZXQgaHR0cDovL2dpdC5lY2xpcHNlLm9yZy9jL2pkdC9lY2xpcHNlLmpk dC5jb3JlLmdpdC9zbmFwc2hvdC8kKFRBRykudGFyLmd6CisJdGFyIHhmICQo VEFHKS50YXIuZ3oKKwlybSAtcmYgb3JnLmVjbGlwc2UuamR0LmNvcmUKKwlt a2RpciBvcmcuZWNsaXBzZS5qZHQuY29yZQorCWNwICQoVEFHKS9vcmcuZWNs aXBzZS5qZHQuY29yZS9zY3JpcHRzL2Fib3V0Lmh0bWwgXAorCSAgb3JnLmVj bGlwc2UuamR0LmNvcmUvLgorCWNwICQoVEFHKS9vcmcuZWNsaXBzZS5qZHQu Y29yZS9zY3JpcHRzL2J1aWxkLnhtbCBcCisJICBvcmcuZWNsaXBzZS5qZHQu Y29yZS8uCisJdGFyIC1jIC1mIC0gLUMgJChUQUcpL29yZy5lY2xpcHNlLmpk dC5jb3JlL2NvbXBpbGVyIG9yZyBcCisJICB8IHRhciAteCAtZiAtIC1DIG9y Zy5lY2xpcHNlLmpkdC5jb3JlLworCWZpbmQgb3JnLmVjbGlwc2UuamR0LmNv cmUgLW5hbWUgQ2hlY2tEZWJ1Z0F0dHJpYnV0ZXMuamF2YSB8IHhhcmdzIC1y IHJtIC1mCisJZmluZCBvcmcuZWNsaXBzZS5qZHQuY29yZSAtbmFtZSBCdWls ZEphckluZGV4LmphdmEgfCB4YXJncyAtciBybSAtZgorCXRhciAtYyAtZiAt IC1DICQoVEFHKS9vcmcuZWNsaXBzZS5qZHQuY29yZS9iYXRjaCBvcmcgXAor CSAgfCB0YXIgLXggLWYgLSAtQyBvcmcuZWNsaXBzZS5qZHQuY29yZS8KKwlt a2RpciAtcCBvcmcuZWNsaXBzZS5qZHQuY29yZS9NRVRBLUlORi9zZXJ2aWNl cworCXByaW50ZiAnb3JnLmVjbGlwc2UuamR0LmludGVybmFsLmNvbXBpbGVy LnRvb2wuRWNsaXBzZUNvbXBpbGVyICNFY2xpcHNlIGNvbXBpbGVyJyBcCisJ ICA+IG9yZy5lY2xpcHNlLmpkdC5jb3JlL01FVEEtSU5GL3NlcnZpY2VzL2ph dmF4LnRvb2xzLkphdmFDb21waWxlcgogCi1jaGVja291dDoKLQljdnMgLWQg JChjdnNyb290KSBjbyAtciQoVEFHKSBvcmcuZWNsaXBzZS5qZHQuY29yZQot Ci1TT1VSQ0VTID0gb3JnIG9yZy5lY2xpcHNlLmpkdC5jb3JlL2JhdGNoIG9y Zy5lY2xpcHNlLmpkdC5jb3JlL2NvbXBpbGVyCitTT1VSQ0VTID0gb3JnIG9y Zy5lY2xpcHNlLmpkdC5jb3JlCiAKIE9VVFBVVCA9IGJpbgogCkBAIC0zMSwx NyArNDQsMTggQEAKIGNvbXBpbGU6CiAJQG1rZGlyIC1wICQoT1VUUFVUKQog CWZpbmQgJChTT1VSQ0VTKSAtbmFtZSAnKi5qYXZhJyA+IExpc3QKLQllY2og LWQgJChPVVRQVVQpIC0xLjQgLW5vd2FybiAtZyBATGlzdAorCWVjaiAtZCAk KE9VVFBVVCkgLTEuNSAtbm93YXJuIC1nIEBMaXN0CisJc2V0IC1lOyBcCiAJ aGVyZT1gcHdkYDsgZm9yIGRpciBpbiAkKFNPVVJDRVMpOyBkbyBcCi0JICAo Y2QgJCRkaXI7IGZpbmQgLiAtbmFtZSAnKi5wcm9wZXJ0aWVzJyAtbyAtbmFt ZSAnKi5yc2MnIHwgXAorCSAgKGNkICQkZGlyOyBmaW5kIC4gLW5hbWUgJyou cHJvcGVydGllcycgLW8gLW5hbWUgJyoucHJvcHMnIC1vIC1uYW1lICcqLnJz YycgfCBcCiAJICAgd2hpbGUgcmVhZCB4OyBkbyBcCiAJICAgICBlY2hvICJj cCAkJHggJCRoZXJlLyQoT1VUUFVUKS8kJHgiOyBcCisJICAgICBta2RpciAt cCAkJChkaXJuYW1lICQkaGVyZS8kKE9VVFBVVCkvJCR4KTsgXAogCSAgICAg Y3AgJCR4ICQkaGVyZS8kKE9VVFBVVCkvJCR4OyBcCiAJICAgZG9uZSk7IFwK IAlkb25lCiAJY2F0IGdjYy5wcm9wZXJ0aWVzID4+ICQoT1VUUFVUKS9vcmcv ZWNsaXBzZS9qZHQvaW50ZXJuYWwvY29tcGlsZXIvYmF0Y2gvbWVzc2FnZXMu cHJvcGVydGllcwogCW1rZGlyIC1wICQoT1VUUFVUKS9NRVRBLUlORgotCWNw IG9yZy5lY2xpcHNlLmpkdC5jb3JlL01FVEEtSU5GL01BTklGRVNULk1GICQo T1VUUFVUKS9NRVRBLUlORgogCiAjIE9uY2UgcGVyIEdDQyByZWxlYXNlIHlv dSBzaG91bGQgdXBsb2FkIGFuIGFwcHJvcHJpYXRlIGphci4KICMgRG9uJ3Qg Y2hhbmdlIHRoZXNlIG9uY2UgdGhlIHJlbGVhc2UgaXMgb3V0LgpAQCAtNTEs NCArNjUsNCBAQAogCXNjcCBlY2ouamFyICQoZGVzdGluYXRpb24pL2Vjai0k KFJFTEVBU0UpLmphcgogCXNjcCBlY2otc291cmNlLnRhci5iejIgJChkZXN0 aW5hdGlvbikvZWNqLSQoUkVMRUFTRSktc291cmNlLnRhci5iejIKIAotLlBI T05ZOiBhbGwgbG9naW4gY2hlY2tvdXQgZWNqLmphciBjb21waWxlIHVwbG9h ZAorLlBIT05ZOiBhbGwgbG9naW4gcHJlcGFyZSBlY2ouamFyIGNvbXBpbGUg dXBsb2FkCkluZGV4OiBvcmcvZWNsaXBzZS9qZHQvaW50ZXJuYWwvY29tcGls ZXIvYmF0Y2gvR0NDTWFpbi5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvcmh1Zy9lY2xpcHNlLWdjai9vcmcvZWNsaXBzZS9q ZHQvaW50ZXJuYWwvY29tcGlsZXIvYmF0Y2gvR0NDTWFpbi5qYXZhLHYKcmV0 cmlldmluZyByZXZpc2lvbiAxLjgKZGlmZiAtdSAtcjEuOCBHQ0NNYWluLmph dmEKLS0tIG9yZy9lY2xpcHNlL2pkdC9pbnRlcm5hbC9jb21waWxlci9iYXRj aC9HQ0NNYWluLmphdmEJMTEgU2VwIDIwMDkgMTA6NTk6MjEgLTAwMDAJMS44 CisrKyBvcmcvZWNsaXBzZS9qZHQvaW50ZXJuYWwvY29tcGlsZXIvYmF0Y2gv R0NDTWFpbi5qYXZhCTEwIERlYyAyMDEzIDE1OjQ3OjM1IC0wMDAwCkBAIC0y OSw2ICsyOSw3IEBACiBpbXBvcnQgb3JnLmVjbGlwc2UuamR0LmludGVybmFs LmNvbXBpbGVyLmVudi5BY2Nlc3NSdWxlOwogaW1wb3J0IG9yZy5lY2xpcHNl LmpkdC5pbnRlcm5hbC5jb21waWxlci5lbnYuQWNjZXNzUnVsZVNldDsKIGlt cG9ydCBvcmcuZWNsaXBzZS5qZHQuaW50ZXJuYWwuY29tcGlsZXIuaW1wbC5D b21waWxlck9wdGlvbnM7CitpbXBvcnQgb3JnLmVjbGlwc2UuamR0LmludGVy bmFsLmNvbXBpbGVyLnByb2JsZW0uUHJvYmxlbVNldmVyaXRpZXM7CiBpbXBv cnQgb3JnLmVjbGlwc2UuamR0LmludGVybmFsLmNvbXBpbGVyLnV0aWwuTWVz c2FnZXM7CiBpbXBvcnQgb3JnLmVjbGlwc2UuamR0LmludGVybmFsLmNvbXBp bGVyLnV0aWwuU3VmZml4Q29uc3RhbnRzOwogCkBAIC00NjMsNyArNDY0LDcg QEAKIAkJfQogCiAJCWlmIChpbmhpYml0QWxsV2FybmluZ3MpCi0JCQlkaXNh YmxlV2FybmluZ3MoKTsKKwkJCWRpc2FibGVBbGwoUHJvYmxlbVNldmVyaXRp ZXMuV2FybmluZyk7CiAJCWlmICh0cmVhdFdhcm5pbmdzQXNFcnJvcnMpCiAJ CQl0dXJuV2FybmluZ3NUb0Vycm9ycygpOwogCg== --------------050603020409050706070607--