From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Jeff Law <law@redhat.com>,
tromey@redhat.com, aph@redhat.com, per@bothner.com
Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.
Date: Mon, 11 Aug 2014 20:20:00 -0000 [thread overview]
Message-ID: <53E92581.2030402@gmail.com> (raw)
In-Reply-To: <53E72BE0.1090104@gmail.com>
On 08/10/2014 04:22 PM, Chen Gang wrote:
>
> I guess, I find the root cause:
>
Although I say "I guess", in fact, I already had related proofs for it.
- When configure "libjava/classpath", "--disable-core-jni" is passed
as parameter explicitly (can check "x86_64-.../libjava/classpatch/
config.log" to know about it).
- if pass "--disable-core-jni" to "libjava/classpatch/configure", it
will disable 'JNIDIR' in "libjava/classpath/native/jni/Makefile". If
remove "--disable-core-jni", it enables 'JNIDIR' to build java-lang.
- After grep "--disaboe-core-jni", only "libjava/configure(.ac)" do it
(and hard code it).
For me, the proofs are enough, and the code in "libjava/configure(.ac)"
are also obvious for it.
So please check it is whether it is the root cause, when you have time.
Thanks.
> In "gcc/libjava/configure", "--disable-core-jni" is hardcoded manually
> for classpath with FIXME, then all related trying are useless. For me,
> if have parameter "--enable-core-jni", need skip "--disable-core-jni".
>
> The related information in gcc/libjava/configure:
>
> 6820 # Set up to configure Classpath.
> 6821 # FIXME: no supported way to pass args in autoconf.
> 6822 # Disable tool wrappers to avoid ltdl.h configure check.
> 6823 ac_configure_args="$ac_configure_args --disable-tool-wrappers"
> 6824 ac_configure_args="$ac_configure_args --disable-load-library"
> 6825 ac_configure_args="$ac_configure_args --${LIBGCJDEBUG}-debug"
> 6826 ac_configure_args="$ac_configure_args --enable-default-toolkit=$TOOLKIT"
> 6827 dir1=`cd $srcdir && pwd`
> 6828 dir2=`pwd`
> 6829 ac_configure_args="$ac_configure_args --with-vm-classes=$dir1:$dir2"
> 6830 ac_configure_args="$ac_configure_args --disable-core-jni"
> 6831 ac_configure_args="$ac_configure_args --disable-examples"
> 6832 ac_configure_args="$ac_configure_args --with-glibj=build"
>
>
>
> On 08/10/2014 01:58 PM, Chen Gang wrote:
>>
>> On 8/3/14 13:50, Chen Gang wrote:
>>> Excuse me, after tried, I still did not know hot to build the source
>>> code for "x86_64-unknown-linux-gnu/32/libjava/classpath/native/jni".
>>> What I have done is:
>>>
>>> - ../gcc/configure --enable-core-jni --enable-languages=c,c++,java
>>> make all-target-libjava
>>>
>>> - also try "../gcc/configure && make", but get same result.
>>>
>>> - I also enable JNIDIRS in "x86_64-unknown-linux-gnu/libjava/classpath
>>> /native/jni/Makefile" manually, but still no effect.
>>>
>>> Welcome any ideas, suggestions or completions for it, thank.
>>>
>>> Also sorry, I did not finish sending patch v2 for it within 2014-08-03,
>>> one excuse is: for each complete building, it needs 12-15 hours under my
>>> laptop. So next, I shall buy a PC for it (also for linux kernel).
>>>
>>
>> After try again, I can let it pass building, but I do not know whether
>> it is enough for this patch:
>>
>> - ../gcc/configure --enable-core-jni && make
>>
>> - enable JNIDIRS in x86_64-unknown-linux-gnu/libjava/classpath/native/
>> Makefile, manually.
>>
>> - then "make && make check" succeed with all related things are built.
>>
>> Before send patch v2 for it, I shall wait the confirmation from related
>> members.
>>
>>
>> Thanks.
>>
>
--
Chen Gang
Open share and attitude like air water and life which God blessed
next parent reply other threads:[~2014-08-11 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53D63F19.4050405@gmail.com>
[not found] ` <53D7313C.8080203@gmail.com>
[not found] ` <53D908CA.3060405@gmail.com>
[not found] ` <53D9C19D.7040704@redhat.com>
[not found] ` <53D9CD3B.2040803@gmail.com>
[not found] ` <53DB234B.8090708@gmail.com>
[not found] ` <53DDCD8A.5000702@gmail.com>
[not found] ` <53E70A1A.1040803@gmail.com>
[not found] ` <53E72BE0.1090104@gmail.com>
2014-08-11 20:20 ` Chen Gang [this message]
2014-08-13 4:09 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E92581.2030402@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=aph@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=per@bothner.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).