From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4804 invoked by alias); 13 Aug 2014 04:09:53 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 4777 invoked by uid 89); 13 Aug 2014 04:09:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 13 Aug 2014 04:09:48 +0000 Received: by mail-pa0-f49.google.com with SMTP id hz1so14152167pad.36 for ; Tue, 12 Aug 2014 21:09:46 -0700 (PDT) X-Received: by 10.70.89.76 with SMTP id bm12mr1854249pdb.40.1407902986481; Tue, 12 Aug 2014 21:09:46 -0700 (PDT) Received: from ShengShiZhuChengdeMacBook-Pro.local ([124.126.233.219]) by mx.google.com with ESMTPSA id fq1sm538699pbb.32.2014.08.12.21.09.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Aug 2014 21:09:45 -0700 (PDT) Message-ID: <53EAE623.8020606@gmail.com> Date: Wed, 13 Aug 2014 04:09:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Jeff Law , tromey@redhat.com, aph@redhat.com, per@bothner.com CC: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated. References: <53D63F19.4050405@gmail.com> <53D7313C.8080203@gmail.com> <53D908CA.3060405@gmail.com> <53D9C19D.7040704@redhat.com> <53D9CD3B.2040803@gmail.com> <53DB234B.8090708@gmail.com> <53DDCD8A.5000702@gmail.com> <53E70A1A.1040803@gmail.com> <53E72BE0.1090104@gmail.com> <53E92581.2030402@gmail.com> In-Reply-To: <53E92581.2030402@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-q3/txt/msg00008.txt.bz2 On 8/12/14 4:20, Chen Gang wrote: > On 08/10/2014 04:22 PM, Chen Gang wrote: >> >> I guess, I find the root cause: >> I have given the test, if remove the hardcoded "--disable-core-jni" from libjava/configure, we can let "JNIDIR" enabled. So I am sure, it must be the root cause. Thanks. > > Although I say "I guess", in fact, I already had related proofs for it. > > - When configure "libjava/classpath", "--disable-core-jni" is passed > as parameter explicitly (can check "x86_64-.../libjava/classpatch/ > config.log" to know about it). > > - if pass "--disable-core-jni" to "libjava/classpatch/configure", it > will disable 'JNIDIR' in "libjava/classpath/native/jni/Makefile". If > remove "--disable-core-jni", it enables 'JNIDIR' to build java-lang. > > - After grep "--disaboe-core-jni", only "libjava/configure(.ac)" do it > (and hard code it). > > For me, the proofs are enough, and the code in "libjava/configure(.ac)" > are also obvious for it. > > > So please check it is whether it is the root cause, when you have time. > > Thanks. > >> In "gcc/libjava/configure", "--disable-core-jni" is hardcoded manually >> for classpath with FIXME, then all related trying are useless. For me, >> if have parameter "--enable-core-jni", need skip "--disable-core-jni". >> >> The related information in gcc/libjava/configure: >> >> 6820 # Set up to configure Classpath. >> 6821 # FIXME: no supported way to pass args in autoconf. >> 6822 # Disable tool wrappers to avoid ltdl.h configure check. >> 6823 ac_configure_args="$ac_configure_args --disable-tool-wrappers" >> 6824 ac_configure_args="$ac_configure_args --disable-load-library" >> 6825 ac_configure_args="$ac_configure_args --${LIBGCJDEBUG}-debug" >> 6826 ac_configure_args="$ac_configure_args --enable-default-toolkit=$TOOLKIT" >> 6827 dir1=`cd $srcdir && pwd` >> 6828 dir2=`pwd` >> 6829 ac_configure_args="$ac_configure_args --with-vm-classes=$dir1:$dir2" >> 6830 ac_configure_args="$ac_configure_args --disable-core-jni" >> 6831 ac_configure_args="$ac_configure_args --disable-examples" >> 6832 ac_configure_args="$ac_configure_args --with-glibj=build" >> >> >> >> On 08/10/2014 01:58 PM, Chen Gang wrote: >>> >>> On 8/3/14 13:50, Chen Gang wrote: >>>> Excuse me, after tried, I still did not know hot to build the source >>>> code for "x86_64-unknown-linux-gnu/32/libjava/classpath/native/jni". >>>> What I have done is: >>>> >>>> - ../gcc/configure --enable-core-jni --enable-languages=c,c++,java >>>> make all-target-libjava >>>> >>>> - also try "../gcc/configure && make", but get same result. >>>> >>>> - I also enable JNIDIRS in "x86_64-unknown-linux-gnu/libjava/classpath >>>> /native/jni/Makefile" manually, but still no effect. >>>> >>>> Welcome any ideas, suggestions or completions for it, thank. >>>> >>>> Also sorry, I did not finish sending patch v2 for it within 2014-08-03, >>>> one excuse is: for each complete building, it needs 12-15 hours under my >>>> laptop. So next, I shall buy a PC for it (also for linux kernel). >>>> >>> >>> After try again, I can let it pass building, but I do not know whether >>> it is enough for this patch: >>> >>> - ../gcc/configure --enable-core-jni && make >>> >>> - enable JNIDIRS in x86_64-unknown-linux-gnu/libjava/classpath/native/ >>> Makefile, manually. >>> >>> - then "make && make check" succeed with all related things are built. >>> >>> Before send patch v2 for it, I shall wait the confirmation from related >>> members. >>> >>> >>> Thanks. >>> >> > > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed