From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10898 invoked by alias); 6 Oct 2014 15:30:38 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 10875 invoked by uid 89); 6 Oct 2014 15:30:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,MEDICAL_SUBJECT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pd0-f173.google.com Received: from mail-pd0-f173.google.com (HELO mail-pd0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 06 Oct 2014 15:30:36 +0000 Received: by mail-pd0-f173.google.com with SMTP id g10so3448055pdj.18 for ; Mon, 06 Oct 2014 08:30:34 -0700 (PDT) X-Received: by 10.70.124.226 with SMTP id ml2mr18932451pdb.69.1412609434348; Mon, 06 Oct 2014 08:30:34 -0700 (PDT) Received: from ShengShiZhuChengdeMacBook-Pro.local ([223.72.65.50]) by mx.google.com with ESMTPSA id qx4sm13664083pbc.14.2014.10.06.08.30.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Oct 2014 08:30:33 -0700 (PDT) Message-ID: <5432B6F6.4050504@gmail.com> Date: Mon, 06 Oct 2014 15:30:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Andrew Haley , Mike Stump CC: Michael Eager , Jeff Law , davem@redhat.com, gcc-patches List , java-patches@gcc.gnu.org Subject: Re: Libjava test failure Was: [PATCH] microblaze: microblaze.md: Use 'SI' instead of 'VOID' for operand 1 of 'call_value_intern' References: <5430B7E8.1060001@gmail.com> <5430BBBE.8050905@gmail.com> <543215AE.7080206@gmail.com> <543254DB.9020600@redhat.com> <54329EEC.8040609@gmail.com> <54329F17.7050107@redhat.com> <5432A6C5.8040205@gmail.com> <5432A712.2080206@redhat.com> <5432AE7A.2060206@gmail.com> <5432AE68.4030700@redhat.com> In-Reply-To: <5432AE68.4030700@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-q4/txt/msg00010.txt.bz2 On 10/6/14 22:59, Andrew Haley wrote: > On 10/06/2014 04:00 PM, Chen Gang wrote: >> On 10/6/14 22:28, Andrew Haley wrote: [...] >>> The testsuite isn't breaking: it's telling you something useful. >>> >> >> Sorry it is breaked, at present, I temporarily skipped it and then can >> let "make check" finish, the related temporarily skip diff may like >> below (in real action, I modify the related Makefile, directly): > > You're missing what I'm saying. The testuite is not broken. > > You should be running "make -k check". > For me, "make -k check" is suitable for one sub-system (e.g. for cross building, and mainly focus on gcc), but not for global check (full non-cross building check): - "make check" is the standard check for global, so when find new issues (include environment construction), need stop in time. - If one sub-system wants to skip the known issue, it can mark it as 'unexpected', or just simply return 0 to Makefile to let checking continue (I guess, most of other sub-system do in this way). - Or for other members (especially for newbies, e.g. me), he/she can not sure whether the environment construction for testsuite is OK or not: e.g. For our case, after build upstream glibc and let testsuite use it instead of Darwin glibc, all things may go OK. If really it is, it is environments construction (not testsuite or code) issue. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed