From: Matthias Klose <doko@ubuntu.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCJ-patches <java-patches@gcc.gnu.org>,
"gcc-patches@gnu.org" <gcc-patches@gnu.org>
Subject: Re: [patch] [java] bump libgcj soname
Date: Sat, 02 Jan 2016 14:40:00 -0000 [thread overview]
Message-ID: <5687E158.7000401@ubuntu.com> (raw)
In-Reply-To: <20150421143747.GY1725@tucnak.redhat.com>
On 21.04.2015 16:37, Jakub Jelinek wrote:
> On Tue, Apr 21, 2015 at 04:29:52PM +0200, Matthias Klose wrote:
>> On 04/21/2015 04:19 PM, Jakub Jelinek wrote:
>>> On Tue, Apr 21, 2015 at 04:16:18PM +0200, Matthias Klose wrote:
>>>> On 04/21/2015 04:11 PM, Jakub Jelinek wrote:
>>>>> On Tue, Apr 21, 2015 at 04:07:13PM +0200, Matthias Klose wrote:
>>>>>> bump the libgcj soname on the trunk, as done for every release cycle,
>>>>>
>>>>> Is that really needed though these days?
>>>>> Weren't there basically zero changes to libjava (both libjava and
>>>>> libjava/classpath) in the last 2 or more years?
>>>>> The few ones were mostly updating Copyright notices, minor configure
>>>>> changes, but I really haven't seen anything ABI changing for quite a while.
>>>>
>>>> yes, the GCC version is embedded in the GCJ_VERSIONED_LIBDIR
>>>>
>>>> which is defined as
>>>>
>>>> gcjsubdir=gcj-$gcjversion-$libgcj_soversion
>>>> dbexecdir='$(toolexeclibdir)/'$gcjsubdir
>>>
>>> But why is that an argument for bumping it? If both GCC 5 and GCC 6 will
>>> (likely) provide the same ABI in the library, there is no reason not to use
>>> the same directory for those.
>>
>> but currently there are different directories used (gcjversion already changed
>> on the trunk) and compiled into the library. Do you mean that gcjsubdir should
>> be just defined as gcj?
>
> What depends on BASE-VER sure, that is bumped automatically and should track
> the gcc version. But the soname, which is an unrelated number, there is no
> point to bump it. If you have a packaging issue, just solve it on the
> packaging side, but really there is no point to yearly bump a soname of
> something that doesn't change at all (and is really dead project for many
> years).
preparing for a test rebuild of the archive, and trying to run gcj-dbtool (from
GCC 5) with libgcj16 (from GCC 6):
$ gcj-dbtool -n /tmp/foo.db
libgcj failure: gcj linkage error.
Incorrect library ABI version detected. Aborting.
Aborted (core dumped)
natClassLoader.cc:_Jv_CheckABIVersion checks the ABI version, which is defined as
libjava/include/jvm.h:#define GCJ_CXX_ABI_VERSION (__GNUC__ * 100000 +
__GNUC_MINOR__ * 1000)
so this will be seen with everything directly linked to libgcj with a libgcj16
upgraded to GCC 6. So what to do? Bump the soname, or discard this check?
In any case, GCJ_CXX_ABI_VERSION should be changed to not include __GNUC_MINOR__
anymore. Maybe for the gcc-5-branch, set it unconditionally to 3 so that it
won't change anymore with future releases from the gcc-5 branch?
Matthias
next prev parent reply other threads:[~2016-01-02 14:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 14:07 Matthias Klose
2015-04-21 14:11 ` Jakub Jelinek
2015-04-21 14:16 ` Matthias Klose
2015-04-21 14:19 ` Jakub Jelinek
2015-04-21 14:29 ` Matthias Klose
2015-04-21 14:37 ` Jakub Jelinek
2016-01-02 14:40 ` Matthias Klose [this message]
2016-01-02 15:40 ` Andrew Haley
2016-01-02 15:53 ` Matthias Klose
2016-01-02 16:11 ` Andrew Haley
2016-01-03 11:38 ` Matthias Klose
2016-01-03 14:17 ` Andrew Haley
2016-01-03 15:52 ` Matthias Klose
2016-01-03 16:23 ` Andrew Haley
2016-01-03 17:34 ` Matthias Klose
2016-01-03 19:04 ` Mike Stump
2016-01-03 22:14 ` Matthias Klose
2015-04-21 17:04 ` Andrew Hughes
2015-04-21 17:10 ` Jakub Jelinek
2015-04-21 17:17 ` Andrew Hughes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5687E158.7000401@ubuntu.com \
--to=doko@ubuntu.com \
--cc=gcc-patches@gnu.org \
--cc=jakub@redhat.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).