public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Matthias Klose <doko@ubuntu.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: GCJ-patches <java-patches@gcc.gnu.org>,
	       GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Don't encode the minor version in the gcj abi version
Date: Thu, 28 Apr 2016 11:45:00 -0000	[thread overview]
Message-ID: <5721F7DA.3050009@ubuntu.com> (raw)
In-Reply-To: <ydd60v280q6.fsf@lokon.CeBiTec.Uni-Bielefeld.DE>

On 28.04.2016 12:52, Rainer Orth wrote:
> Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
>> Matthias Klose <doko@ubuntu.com> writes:
>>
>>> Bumping the version from from 6.0.0 to 6.1.0 broke gcj, because the minor
>>> version is still encoded in the gcj abi, not seen during development of the
>>> 6 series until it was bumped for the final release.
>>
>> This is PR java/70839.
>
> I just noticed that your patch is incomplete: it leaves the now unused
> minor around and incorrectly talks about sub-minor versions...
>
> Here's what I had in the PR instead:
>
> 2016-04-28  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
> 	PR java/70839
> 	* decl.c (parse_version): Remove minor handling.

yes, that looks good. Can't approve it myself.

  reply	other threads:[~2016-04-28 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  7:55 Matthias Klose
2016-04-28  7:56 ` Andrew Haley
2016-04-28  8:39 ` Rainer Orth
2016-04-28 10:52   ` Rainer Orth
2016-04-28 11:45     ` Matthias Klose [this message]
2016-04-28 11:47       ` Andrew Haley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5721F7DA.3050009@ubuntu.com \
    --to=doko@ubuntu.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).