From: Sandra Loosemore <sandra@codesourcery.com>
To: Matthias Klose <doko@ubuntu.com>, Iain Sandoe <iain@codesourcery.com>
Cc: Mike Stump <mikestump@comcast.net>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Jeff Law <law@redhat.com>, Andrew Haley <aph@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
GCJ-patches <java-patches@gcc.gnu.org>
Subject: Re: [PATCH] Delete GCJ
Date: Mon, 21 Nov 2016 16:23:00 -0000 [thread overview]
Message-ID: <58331F83.9080801@codesourcery.com> (raw)
In-Reply-To: <48b62bc3-2870-0113-d165-59057c186e54@ubuntu.com>
On 11/21/2016 05:57 AM, Matthias Klose wrote:
>
> --with-target-bdw-gc=/opt/bdw-gc,32=/opt/bdw-gc32
>
> sets the include and lib dirs by appending include and lib to the paths. If you
> have options --with-target-bdw-gc-include= and --with-target-bdw-gc-lib= as
> well, it overrides the settings done in --with-target-bdw-gc=. This is copied
> from the setting of the gmp/mpfr options.
>
> Any of these options override the automatic discovery using pkg-config.
>
> Please suggest a better wording; I thought that was clear enough (and better
> than the undocumented --enable-libobjc-gc anyway ;)
FAOD, my complaint about your patch is that it essentially said
"The options --with-foo and --with-foo must also be specified together
and override --with-foo."
I'm sure you didn't mean exactly the same --with-foo in all 3 places,
but I'm a dummy about what you really intended to say here.
-Sandra
next prev parent reply other threads:[~2016-11-21 16:23 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 15:13 Andrew Haley
2016-09-05 15:29 ` Matthias Klose
2016-09-05 15:31 ` Andrew Haley
2016-09-05 18:37 ` Eric Gallager
2016-09-05 18:47 ` Andrew Haley
2016-09-05 15:32 ` Matthew Fortune
2016-09-05 15:34 ` Andrew Haley
[not found] ` <FB08E20B-5ED1-45BA-BFA0-11E7807840D2@gmail.com>
2016-09-05 16:17 ` Andrew Haley
2016-09-06 9:06 ` Richard Biener
2016-09-06 9:08 ` Jakub Jelinek
2016-09-06 21:18 ` Jeff Law
2016-09-07 11:41 ` Richard Earnshaw (lists)
2016-09-09 11:03 ` Ian Lance Taylor
2016-09-05 16:26 ` Gerald Pfeifer
2016-09-05 16:30 ` Andrew Haley
2016-09-05 18:40 ` Eric Gallager
2016-09-30 15:34 ` Andrew Haley
2017-01-22 16:51 ` Gerald Pfeifer
2017-01-22 17:17 ` Per Bothner
2017-01-22 18:41 ` Per Bothner
2017-01-23 9:01 ` Andrew Haley
2017-01-23 9:05 ` Jakub Jelinek
2017-01-23 12:52 ` Per Bothner
2017-01-23 13:42 ` Jakub Jelinek
2017-01-23 14:51 ` Andrew Haley
2017-01-22 18:36 ` Gerald Pfeifer
2016-09-10 12:00 ` NightStrike
2016-09-11 8:25 ` Andrew Haley
2016-09-19 15:26 ` Andrew Hughes
2016-10-03 23:12 ` Matthias Klose
2016-10-04 8:40 ` Rainer Orth
2016-10-04 8:41 ` Andrew Haley
2016-10-04 17:23 ` Mike Stump
2016-10-04 17:25 ` Andrew Pinski
2016-10-04 18:40 ` Iain Sandoe
2016-10-05 16:28 ` Jeff Law
[not found] ` <2b5de569-1efd-f407-49c2-c9fa84cc5315@ubuntu.com>
2016-10-06 16:16 ` Matthias Klose
2016-10-06 16:43 ` Rainer Orth
2016-10-06 16:47 ` Iain Sandoe
2016-10-06 16:54 ` Matthias Klose
2016-10-06 16:56 ` Rainer Orth
2016-10-06 17:10 ` Iain Sandoe
2016-10-06 18:01 ` Mike Stump
2016-10-06 23:59 ` Matthias Klose
2016-10-07 8:31 ` Iain Sandoe
2016-10-10 4:03 ` Matthias Klose
2016-10-10 7:58 ` Iain Sandoe
2016-11-20 20:42 ` Matthias Klose
2016-11-21 5:34 ` Sandra Loosemore
2016-11-21 10:24 ` Iain Sandoe
2016-11-21 12:57 ` Matthias Klose
2016-11-21 16:23 ` Sandra Loosemore [this message]
2016-11-21 16:40 ` Matthias Klose
2016-11-21 17:16 ` Rainer Orth
2016-11-21 23:23 ` Matthias Klose
2016-11-22 17:13 ` Sandra Loosemore
2016-11-29 21:23 ` Jeff Law
2016-11-30 1:11 ` Remove stray '@' from install.texi (was Re: [PATCH] Delete GCJ) David Malcolm
2016-11-30 1:20 ` Sandra Loosemore
2016-11-30 1:26 ` David Malcolm
2016-11-21 17:16 ` [PATCH] Delete GCJ Peter Bergner
2016-09-05 22:49 Bernd Edlinger
2016-09-06 0:20 ` Eric Gallager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58331F83.9080801@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=aph@redhat.com \
--cc=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@codesourcery.com \
--cc=java-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).