From: Matthew Fortune <Matthew.Fortune@imgtec.com>
To: Tom Tromey <tom@tromey.com>
Cc: "java-patches@gcc.gnu.org" <java-patches@gcc.gnu.org>,
"'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org)"
<gcc-patches@gcc.gnu.org>, "per@bothner.com" <per@bothner.com>,
"aph@redhat.com" <aph@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: RE: [PATCH] Fix FFI return type for closures in the java interpreter
Date: Tue, 12 Jul 2016 10:20:00 -0000 [thread overview]
Message-ID: <6D39441BF12EF246A7ABCE6654B023537E474A22@HHMAIL01.hh.imgtec.org> (raw)
In-Reply-To: <87k2h9t3en.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
> >>>>> "Matthew" == Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
>
> Matthew> I'm not sure this will matter if the only arch is x86 as
> Matthew> ffi_arg will be 32-bit anyway there.
>
> Aha, right. Thanks for looking.
>
> Matthew> There would need to be a
> Matthew> 64bit arch using the raw api. I don't really understand what
> Matthew> the raw api is, the references to it in the code seemed
> Matthew> cryptic.
>
> IIRC it's to exploit the x86 calling convention to make ffi calls a bit
> more efficient for libgcj.
Sorry for the long delay...
I have tested this now with -m32 multilib on x86_64-pc-linux-gnu and there
are no regressions.
> Matthew> libjava/
> Matthew> * interpret-run.cc: Use ffi_arg for FFI integer return types.
> Matthew> libjava/testsuite/
> Matthew> * libjava.jar/arraysort.java: New file.
> Matthew> * libjava.jar/arraysort.jar: New file.
> Matthew> * libjava.jar/arraysort.out: New file.
> Matthew> * libjava.jar/arraysort.xfail: New file.
>
> This is ok.
> Could you check? I think a -m32 build ought to show it. Maybe your
> x86-64 build already did this?
Still OK to commit?
Thanks,
Matthew
next prev parent reply other threads:[~2016-07-12 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 20:17 Matthew Fortune
2016-06-27 21:20 ` Tom Tromey
2016-06-28 8:08 ` Tom Tromey
2016-06-28 15:30 ` Matthew Fortune
2016-06-28 21:22 ` Tom Tromey
2016-07-12 10:20 ` Matthew Fortune [this message]
2016-07-12 16:32 ` Tom Tromey
2016-07-13 21:36 ` Matthew Fortune
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D39441BF12EF246A7ABCE6654B023537E474A22@HHMAIL01.hh.imgtec.org \
--to=matthew.fortune@imgtec.com \
--cc=aph@redhat.com \
--cc=aurelien@aurel32.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=per@bothner.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).