From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120712 invoked by alias); 12 Jul 2016 10:20:21 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 120677 invoked by uid 89); 12 Jul 2016 10:20:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*aph, ffi, exploit, (unknown) X-Spam-User: qpsmtpd, 2 recipients X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jul 2016 10:20:10 +0000 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Forcepoint Email with ESMTPS id CF1AE30447DE; Tue, 12 Jul 2016 11:20:04 +0100 (IST) Received: from HHMAIL01.hh.imgtec.org ([fe80::710b:f219:72bc:e0b3]) by hhmail02.hh.imgtec.org ([fe80::5400:d33e:81a4:f775%25]) with mapi id 14.03.0294.000; Tue, 12 Jul 2016 11:20:07 +0100 From: Matthew Fortune To: Tom Tromey CC: "java-patches@gcc.gnu.org" , "'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org)" , "per@bothner.com" , "aph@redhat.com" , Aurelien Jarno Subject: RE: [PATCH] Fix FFI return type for closures in the java interpreter Date: Tue, 12 Jul 2016 10:20:00 -0000 Message-ID: <6D39441BF12EF246A7ABCE6654B023537E474A22@HHMAIL01.hh.imgtec.org> References: <6D39441BF12EF246A7ABCE6654B023537E45FD9F@HHMAIL01.hh.imgtec.org> <87shvyib1n.fsf@tromey.com> <8760stviqj.fsf@tromey.com> <6D39441BF12EF246A7ABCE6654B023537E46241B@HHMAIL01.hh.imgtec.org> <87k2h9t3en.fsf@tromey.com> In-Reply-To: <87k2h9t3en.fsf@tromey.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2016-q3/txt/msg00000.txt.bz2 Tom Tromey writes: > >>>>> "Matthew" =3D=3D Matthew Fortune write= s: >=20 > Matthew> I'm not sure this will matter if the only arch is x86 as > Matthew> ffi_arg will be 32-bit anyway there. >=20 > Aha, right. Thanks for looking. >=20 > Matthew> There would need to be a > Matthew> 64bit arch using the raw api. I don't really understand what > Matthew> the raw api is, the references to it in the code seemed > Matthew> cryptic. >=20 > IIRC it's to exploit the x86 calling convention to make ffi calls a bit > more efficient for libgcj. Sorry for the long delay... I have tested this now with -m32 multilib on x86_64-pc-linux-gnu and there are no regressions. > Matthew> libjava/ > Matthew> * interpret-run.cc: Use ffi_arg for FFI integer return types. > Matthew> libjava/testsuite/ > Matthew> * libjava.jar/arraysort.java: New file. > Matthew> * libjava.jar/arraysort.jar: New file. > Matthew> * libjava.jar/arraysort.out: New file. > Matthew> * libjava.jar/arraysort.xfail: New file. > > This is ok. > Could you check? I think a -m32 build ought to show it. Maybe your > x86-64 build already did this? Still OK to commit? Thanks, Matthew