public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Matthew Fortune <Matthew.Fortune@imgtec.com>
To: Tom Tromey <tom@tromey.com>
Cc: "'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org)"
	<gcc-patches@gcc.gnu.org>,
	"java-patches@gcc.gnu.org"	<java-patches@gcc.gnu.org>,
	"aurelien@aurel32.net" <aurelien@aurel32.net>
Subject: RE: [PATCH] Fix FFI return type for proxy classes
Date: Wed, 13 Jul 2016 21:37:00 -0000	[thread overview]
Message-ID: <6D39441BF12EF246A7ABCE6654B023537E478942@HHMAIL01.hh.imgtec.org> (raw)
In-Reply-To: <874m7upz18.fsf@tromey.com>

Tom Tromey <tom@tromey.com> writes:
> >>>>> "Matthew" == Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
> 
> Matthew> Tested on: x86_64-pc-linux-gnu (default and -m32), mips-linux-gnu
> Matthew> mipsel-linux-gnuabi64 with no regressions. The new test only failed
> Matthew> on mips-linux-gnu prior to patching libjava.
> 
> Matthew> libjava/
> Matthew> 	* java/lang/reflect/natVMProxy.cc (unbox): Use ffi_arg for
> Matthew> 	integer return types smaller than a word.
> Matthew> 	* testsuite/libjava.jar/ReturnInvocationHandler.java: New file.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.jar: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.java: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.out: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.xfail: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnTypes.java: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnTypesImpl.java: Likewise.
> 
> Thanks for writing this.
> This is ok.

Thanks for the review.

Committed as r238312. This also needs a backport to GCC 5 and 6 but I will
give it a week or so before proposing.

Thanks,
Matthew

      reply	other threads:[~2016-07-13 21:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 10:39 Matthew Fortune
2016-07-12 17:06 ` Tom Tromey
2016-07-13 21:37   ` Matthew Fortune [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D39441BF12EF246A7ABCE6654B023537E478942@HHMAIL01.hh.imgtec.org \
    --to=matthew.fortune@imgtec.com \
    --cc=aurelien@aurel32.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).