From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39800 invoked by alias); 13 Jul 2016 21:37:37 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 39783 invoked by uid 89); 13 Jul 2016 21:37:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Jul 2016 21:37:26 +0000 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Forcepoint Email with ESMTPS id E2AA638977C8D; Wed, 13 Jul 2016 22:37:19 +0100 (IST) Received: from HHMAIL01.hh.imgtec.org ([fe80::710b:f219:72bc:e0b3]) by hhmail02.hh.imgtec.org ([fe80::5400:d33e:81a4:f775%25]) with mapi id 14.03.0294.000; Wed, 13 Jul 2016 22:37:23 +0100 From: Matthew Fortune To: Tom Tromey CC: "'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org)" , "java-patches@gcc.gnu.org" , "aurelien@aurel32.net" Subject: RE: [PATCH] Fix FFI return type for proxy classes Date: Wed, 13 Jul 2016 21:37:00 -0000 Message-ID: <6D39441BF12EF246A7ABCE6654B023537E478942@HHMAIL01.hh.imgtec.org> References: <6D39441BF12EF246A7ABCE6654B023537E474A5F@HHMAIL01.hh.imgtec.org> <874m7upz18.fsf@tromey.com> In-Reply-To: <874m7upz18.fsf@tromey.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2016-q3/txt/msg00006.txt.bz2 Tom Tromey writes: > >>>>> "Matthew" =3D=3D Matthew Fortune write= s: >=20 > Matthew> Tested on: x86_64-pc-linux-gnu (default and -m32), mips-linux-gnu > Matthew> mipsel-linux-gnuabi64 with no regressions. The new test only fai= led > Matthew> on mips-linux-gnu prior to patching libjava. >=20 > Matthew> libjava/ > Matthew> * java/lang/reflect/natVMProxy.cc (unbox): Use ffi_arg for > Matthew> integer return types smaller than a word. > Matthew> * testsuite/libjava.jar/ReturnInvocationHandler.java: New file. > Matthew> * testsuite/libjava.jar/ReturnProxyTest.jar: Likewise. > Matthew> * testsuite/libjava.jar/ReturnProxyTest.java: Likewise. > Matthew> * testsuite/libjava.jar/ReturnProxyTest.out: Likewise. > Matthew> * testsuite/libjava.jar/ReturnProxyTest.xfail: Likewise. > Matthew> * testsuite/libjava.jar/ReturnTypes.java: Likewise. > Matthew> * testsuite/libjava.jar/ReturnTypesImpl.java: Likewise. >=20 > Thanks for writing this. > This is ok. Thanks for the review. Committed as r238312. This also needs a backport to GCC 5 and 6 but I will give it a week or so before proposing. Thanks, Matthew