public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
	 gcc-patches@gcc.gnu.org,  java-patches@gcc.gnu.org,
	 Ian Lance Taylor <iant@google.com>
Subject: Re: [PATCH v2] Re: avoid useless if-before-free tests
Date: Tue, 08 Mar 2011 19:13:00 -0000	[thread overview]
Message-ID: <871v2hpgsb.fsf@rho.meyering.net> (raw)
In-Reply-To: <yddwrk91met.fsf@manam.CeBiTec.Uni-Bielefeld.DE> (Rainer Orth's	message of "Tue, 08 Mar 2011 19:45:30 +0100")

Rainer Orth wrote:
> Jim Meyering <jim@meyering.net> writes:
>>> the change at hand.  And please don't change the alignment of entries
>>> with multiple email addresses.
>>
>> Changing 8-spaces to a TAB does not affect alignment when you're
>> looking at the ChangeLog file itself with standard tab setting.
>>
>> Perhaps you looked at a hunk like the following and mistook it
>> for one that introduces an alignment change?
>>
>>  2011-11-04  Eric Botcazou  <ebotcazou@adacore.com>
>> -            Jakub Jelinek  <jakub@redhat.com>
>> +	   Jakub Jelinek  <jakub@redhat.com>
>>
>> It does not.
>
> I'm pretty sure it does: before, you have 12 SPC, afterwards you have
> TAB + 3 SPC, which is equivalent to 11 SPC in my book.

Here's the precise excerpt from my patch:

 2011-11-04  Eric Botcazou  <ebotcazou@adacore.com>
-            Jakub Jelinek  <jakub@redhat.com>
+	    Jakub Jelinek  <jakub@redhat.com>

That has TAB + 4, so induced no alignment change.

> I honestly don't see the point of this whitespace change unless done
> across all ChangeLogs, not just a few that you happen to touch.

As I said, it's gone, now, from my patch.
If no one objects, I'll normalize all ChangeLog files.

  reply	other threads:[~2011-03-08 19:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zkp9zmq0.fsf@rho.meyering.net>
2011-03-05 19:16 ` Joseph S. Myers
2011-03-07 19:52   ` Dr Andrew John Hughes
2011-03-07 22:47     ` Joseph S. Myers
2011-03-08 16:57       ` Dr Andrew John Hughes
2011-03-08 17:07         ` Andrew Haley
2011-03-08 17:17         ` Jim Meyering
2011-03-08 10:45   ` Jim Meyering
2011-03-08 14:21   ` [PATCH v2] " Jim Meyering
2011-03-08 14:30     ` Rainer Orth
2011-03-08 15:28       ` Ian Lance Taylor
2011-03-08 15:36         ` Jakub Jelinek
2011-03-08 17:03       ` Jim Meyering
2011-03-08 18:45         ` Rainer Orth
2011-03-08 19:13           ` Jim Meyering [this message]
2011-03-08 19:20             ` Rainer Orth
2011-03-08 19:39               ` Jakub Jelinek
2011-03-08 17:54     ` [PATCH v3] " Jim Meyering
2011-03-08 19:34       ` DJ Delorie
2011-03-15  9:19       ` Janne Blomqvist
2011-03-15 10:03         ` [PATCH gcc/fortran] get rid of gfc_free Jim Meyering
2011-03-15 10:08           ` Jakub Jelinek
2011-03-15 10:27             ` Jim Meyering
2011-03-15 14:18           ` Janne Blomqvist
2011-03-15 18:21             ` Jim Meyering
2011-03-24 16:51         ` [PATCH v3] Re: avoid useless if-before-free tests Jim Meyering
2011-04-15  7:26           ` Janne Blomqvist
2011-04-15  7:54             ` Jim Meyering
2011-04-15  8:20               ` Janne Blomqvist
2011-04-15  8:23                 ` Jim Meyering
2011-04-15 13:20                 ` Tom Tromey
2011-04-15 17:52                   ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871v2hpgsb.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@google.com \
    --cc=java-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).