From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Matthew Fortune <Matthew.Fortune@imgtec.com>,
"java-patches\@gcc.gnu.org" <java-patches@gcc.gnu.org>,
"'gcc-patches\@gcc.gnu.org' \(gcc-patches\@gcc.gnu.org\)"
<gcc-patches@gcc.gnu.org>, "per\@bothner.com" <per@bothner.com>,
"aph\@redhat.com" <aph@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH] Fix FFI return type for closures in the java interpreter
Date: Tue, 28 Jun 2016 08:08:00 -0000 [thread overview]
Message-ID: <8760stviqj.fsf@tromey.com> (raw)
In-Reply-To: <87shvyib1n.fsf@tromey.com> (Tom Tromey's message of "Mon, 27 Jun 2016 15:20:20 -0600")
>>>>> "Matthew" == Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
Matthew> I've identified a latent bug in the java interpreter that affects MIPS
Matthew> n32 and n64 ABIs both little and big endian and, I presume, any 64-bit
Matthew> big endian target with int as 32-bit.
[...]
Matthew> libjava/
Matthew> * interpret-run.cc: Use ffi_arg for FFI integer return types.
Matthew> libjava/testsuite/
Matthew> * libjava.jar/arraysort.java: New file.
Matthew> * libjava.jar/arraysort.jar: New file.
Matthew> * libjava.jar/arraysort.out: New file.
Matthew> * libjava.jar/arraysort.xfail: New file.
Tom> This is ok.
It occurred to me that this might not be correct on platforms using the
Java raw API; which I think is just x86.
I'm actually not sure -- I don't remember (if I ever knew) if the raw
API has the same return-value promotion rules as the ordinary API.
Could you check? I think a -m32 build ought to show it. Maybe your
x86-64 build already did this?
thanks,
Tom
next prev parent reply other threads:[~2016-06-28 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 20:17 Matthew Fortune
2016-06-27 21:20 ` Tom Tromey
2016-06-28 8:08 ` Tom Tromey [this message]
2016-06-28 15:30 ` Matthew Fortune
2016-06-28 21:22 ` Tom Tromey
2016-07-12 10:20 ` Matthew Fortune
2016-07-12 16:32 ` Tom Tromey
2016-07-13 21:36 ` Matthew Fortune
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760stviqj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=aph@redhat.com \
--cc=aurelien@aurel32.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=per@bothner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).