From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28905 invoked by alias); 18 Oct 2013 02:27:26 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 28885 invoked by uid 89); 18 Oct 2013 02:27:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Oct 2013 02:27:24 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9I2RNJg009699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Oct 2013 22:27:23 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9I2RLSO004270 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 17 Oct 2013 22:27:22 -0400 From: Tom Tromey To: Andrew Cc: java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] PR58669: does not detect all cpu cores/threads References: <20131018011541.GA29495@carrie.the212.com> Date: Fri, 18 Oct 2013 02:27:00 -0000 In-Reply-To: <20131018011541.GA29495@carrie.the212.com> (Andrew's message of "Fri, 18 Oct 2013 02:15:42 +0100") Message-ID: <87a9i7s48n.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-q4/txt/msg00001.txt.bz2 >>>>> "Andrew" == Andrew writes: Andrew> +#ifdef HAVE_UNISTD_H Andrew> + procs = sysconf(_SC_NPROCESSORS_ONLN); Andrew> +#endif Space before the "(". Technically you should probably check for sysconf in configure.ac. I'm not sure whether it matters any more. I think _SC_NPROCESSORS_ONLN is not portable though. Tom