public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Marek Polacek <polacek@redhat.com>
Cc: java-patches@gcc.gnu.org,  GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Java PATCH] Generate declarations in jvgenmain.c
Date: Tue, 07 Oct 2014 16:03:00 -0000	[thread overview]
Message-ID: <87fvezrho1.fsf@tromey.com> (raw)
In-Reply-To: <20141007083129.GB3503@redhat.com> (Marek Polacek's message of	"Tue, 7 Oct 2014 10:31:29 +0200")

>>>>> "Marek" == Marek Polacek <polacek@redhat.com> writes:

Marek> [CCing java-patches now]
Marek> Java testsuite breaks with -std=gnu11 as a default and/or with 
Marek> -Wimplicit-function-declaration on

I don't recall how one gets warnings when compiling this generated code,
but if it is generally possible then I think this:

Marek> +  if (indirect)
Marek> +    fprintf (stream, "extern void JvRunMainName ();\n");
Marek> +  else
Marek> +    fprintf (stream, "extern void JvRunMain ();\n");

... will fail with -Wstrict-prototypes, since in C those should
read "(void)" rather than "()".

If it's not possible then no big deal.

Tom

  parent reply	other threads:[~2014-10-07 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-07  8:31 Marek Polacek
2014-10-07 12:21 ` Andrew Haley
2014-10-07 16:03 ` Tom Tromey [this message]
2014-10-07 16:15   ` Marek Polacek
2014-10-07 16:41     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvezrho1.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).