From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27389 invoked by alias); 15 Apr 2011 07:54:37 -0000 Received: (qmail 27363 invoked by uid 22791); 15 Apr 2011 07:54:36 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_BG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx.meyering.net (HELO mx.meyering.net) (82.230.74.64) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Apr 2011 07:54:25 +0000 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 2B71E60110; Fri, 15 Apr 2011 09:54:24 +0200 (CEST) From: Jim Meyering To: Janne Blomqvist Cc: "Joseph S. Myers" , gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PATCH v3] Re: avoid useless if-before-free tests In-Reply-To: (Janne Blomqvist's message of "Fri, 15 Apr 2011 10:26:14 +0300") References: <87zkp9zmq0.fsf@rho.meyering.net> <877hc9r8w6.fsf_-_@rho.meyering.net> <877hc9pkhp.fsf_-_@rho.meyering.net> <87ei5w8nt7.fsf@rho.meyering.net> Date: Fri, 15 Apr 2011 07:54:00 -0000 Message-ID: <87fwpkq79r.fsf@rho.meyering.net> MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2011-q2/txt/msg00010.txt.bz2 Janne Blomqvist wrote: > On Thu, Mar 24, 2011 at 18:51, Jim Meyering wrote: >> Janne Blomqvist wrote: >>> On Tue, Mar 8, 2011 at 19:53, Jim Meyering wrote: >>>> Relative to v2, I've added libgo/ to the list of exempt directories and added >>>> this recently discussed gfc_free patch, at the request of Tobias Burnus. >>>> Also, I corrected an error in fortran's ChangeLog and removed all >>>> whitespace changes from all ChangeLog files. >>> >>> The libgfortran changes are Ok for 4.7. >>> >>> For the gfortran frontend (gcc/fortran/*) I'd prefer if you'd >>> >>> - Replace all calls to "gfc_free (x)" with "free (x)". >>> - Remove the gfc_free() function and prototype. >>> - Remove the free() macro which currently prevents calling free() directly. >> >> Following up, I've refreshed the series but hit a minor snag >> while converting new uses of gfc_free, removing new tests-before-free >> and merging/reordering changes. >> >> Applying this fix first makes my problem go away: > > [snip] > > So, what's the plan here? Do you plan to get a GCC account, do you > already have one, or what? Now that 4.7 is open for development, it's > perhaps the right time to poke the maintainers to get this patch in. > > If you don't have a GCC account, as one of the Fortran maintainers I > can commit the Fortran and libgfortran parts, but someone else will > have to do the rest (were they ever approved, BTW?) as I have only > write after approval privileges for the rest of GCC. Can someone add me to the gcc group? That would help. I already have ssh access to sourceware.org. I've rebased the series a few times, but it's been a week or so. More convertible uses are being added regularly. Plus I have to reorder/split things a little to avoid a new conflict.