public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Hughes <gnu.andrew@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org,
	       Andrew Haley <aph@redhat.com>,
	Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH, libjava/classpath]: Fix overriding recipe for target 'gjdoc' build warning
Date: Thu, 20 Aug 2015 02:48:00 -0000	[thread overview]
Message-ID: <946415796.12688452.1440038906822.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAFULd4bj7q=U+yHrd=+U9NgB=wMQtarvAEw-uAW9xL6SC09keQ@mail.gmail.com>

----- Original Message -----
> On Fri, Aug 7, 2015 at 1:21 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> 
> > Attached patch fixes:
> >
> > Makefile:871: warning: overriding recipe for target 'gjdoc'
> > Makefile:786: warning: ignoring old recipe for target 'gjdoc'
> >
> > build warning when compiling libjava.
> >
> > The problem was in configure.ac: we have to depend gjdoc build on
> > CREATE_WRAPPERS in the same way as other tools are dependent a couple
> > of lines above.
> >
> > While in this area, I also removed obsolete automake < 1.11
> > workaround. As mentioned in HACKING:  "Make sure you have Automake
> > 1.11.1 installed. Exactly that version!"
> >
> > I have included all generated files in the diff. The changes are small
> > and they illustrate the effect of the patch.
> >
> > 2015-08-07  Uros Bizjak  <ubizjak@gmail.com>
> >
> >     * configure.ac (tools/gjdoc): Depend on CREATE_WRAPPERS.
> >     * configure: Regenerate.
> >     * tools/Makefile.am: Remove unneeded dependencies for Automake 1.11.
> >     * tools/Makefile.in: Regenerate.
> >
> > Patch was bootstrapped on x86_64-linux-gnu, Fedora 22.
> >
> > OK for GCC mainline?
> 
> I have committed this patch to GCC mainline SVN repository. Both
> issues can be considered obvious and the fix is trivial.
> 
> Also, it looks like the official classpath repository is a dead place
> for a couple of years.
> 

Hardly.

http://git.savannah.gnu.org/cgit/classpath.git/log/

I've taken the liberty of applying your patch to keep GCJ in sync with its
upstream.

> Uros.
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07

  parent reply	other threads:[~2015-08-20  2:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 11:22 Uros Bizjak
2015-08-11 18:03 ` Uros Bizjak
2015-08-11 18:54   ` Jeff Law
2015-08-11 19:24     ` Andrew Haley
2015-08-11 19:34       ` Jeff Law
2015-08-12  2:48     ` Tom Tromey
2015-08-12 14:44       ` Jeff Law
2015-08-12 14:57         ` Andrew Haley
2015-08-12 16:23           ` Ian Lance Taylor
2015-08-12 16:21         ` Tom Tromey
2015-08-12 16:24           ` Ian Lance Taylor
2015-08-12 16:47             ` Jeff Law
2015-08-12 16:59               ` Ian Lance Taylor
2015-08-13 10:00               ` Richard Biener
2015-08-13 21:31                 ` Jeff Law
2015-08-14  7:44                   ` Richard Biener
2015-08-14  9:24                     ` Andrew Haley
2015-08-20  2:35       ` Andrew Hughes
2015-08-20  4:37         ` Tom Tromey
2015-08-20  8:24           ` Matthias Klose
2015-08-20  8:32             ` Andrew Haley
2015-08-20 14:57               ` Andrew Hughes
2015-08-20 15:27                 ` Andrew Haley
2015-08-20 15:47                   ` Jeff Law
2015-08-20 16:03                     ` Andrew Hughes
2015-08-20 16:08                       ` Andrew Haley
2015-08-20 16:26                         ` Andrew Hughes
2015-08-20 16:38                         ` Richard Biener
2015-08-20 16:39                           ` Andrew Haley
2015-08-20 17:35                       ` Jeff Law
2015-08-20 17:39                         ` Andrew Hughes
2015-08-20 15:52                   ` Andrew Hughes
2015-08-20 16:34                     ` Richard Biener
2015-08-20 16:59                       ` Andrew Hughes
2015-08-20 17:35                         ` Andrew Hughes
2015-08-20 18:05                           ` Richard Biener
2015-08-20 21:06                             ` Joseph Myers
2015-08-20 22:32                             ` Andrew Hughes
2015-08-24 16:39                               ` Jeff Law
2015-08-20 14:58           ` Andrew Hughes
2015-08-20  2:48   ` Andrew Hughes [this message]
2015-08-20  6:20     ` Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=946415796.12688452.1440038906822.JavaMail.zimbra@redhat.com \
    --to=gnu.andrew@redhat.com \
    --cc=aph@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=java-patches@gcc.gnu.org \
    --cc=tromey@redhat.com \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).