From: Diego Novillo <dnovillo@google.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] split tree_type, a.k.a. "tuplifying types"
Date: Tue, 10 May 2011 17:28:00 -0000 [thread overview]
Message-ID: <BANLkTikVJc0R9c-KwFqy1qPxt4YgD-T=Lg@mail.gmail.com> (raw)
In-Reply-To: <20110510161543.GW23480@codesourcery.com>
On Tue, May 10, 2011 at 13:15, Nathan Froyd <froydnj@codesourcery.com> wrote:
> Other types can of course be shrunk, but the memory savings from doing
> so will be negligible
Have you done any measurements on the potential savings?
> +static void
> +lto_input_ts_type_common_tree_pointers (struct lto_input_block *ib,
> + struct data_in *data_in, tree expr)
> +{
> + TYPE_SIZE (expr) = lto_input_tree (ib, data_in);
> + TYPE_SIZE_UNIT (expr) = lto_input_tree (ib, data_in);
> + TYPE_ATTRIBUTES (expr) = lto_input_tree (ib, data_in);
> + TYPE_NAME (expr) = lto_input_tree (ib, data_in);
> + /* Do not stream TYPE_POINTER_TO or TYPE_REFERENCE_TO. */
Add some wording as to why not? This was copied from existing
comments, but I do not remember why we were doing this. Not too
critical, anyway.
OK, otherwise. Thanks for doing this!
Diego.
next prev parent reply other threads:[~2011-05-10 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 16:16 Nathan Froyd
2011-05-10 16:54 ` Mike Stump
2011-05-10 17:28 ` Diego Novillo [this message]
[not found] ` <20110510175015.GY23480@codesourcery.com>
2011-05-10 21:13 ` Michael Matz
2011-05-10 19:28 ` Tom Tromey
2011-05-12 1:39 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikVJc0R9c-KwFqy1qPxt4YgD-T=Lg@mail.gmail.com' \
--to=dnovillo@google.com \
--cc=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).