From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-20391-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 12518 invoked by alias); 12 Aug 2011 16:22:45 -0000
Received: (qmail 12501 invoked by uid 22791); 12 Aug 2011 16:22:44 -0000
X-SWARE-Spam-Status: No, hits=-0.6 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Aug 2011 16:22:31 +0000
Received: by ywe9 with SMTP id 9so2140195ywe.20        for <multiple recipients>; Fri, 12 Aug 2011 09:22:30 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.147.26.9 with SMTP id d9mr1120697yaj.13.1313166150574; Fri, 12 Aug 2011 09:22:30 -0700 (PDT)
Received: by 10.147.82.10 with HTTP; Fri, 12 Aug 2011 09:22:30 -0700 (PDT)
In-Reply-To: <m3bovxqmc2.fsf@fleche.redhat.com>
References: <CABc96T_0THd_tKzdHSjD-xcPd7=dqoFkr0aRwrdvx-h4s2Hnxg@mail.gmail.com>	<CABc96T_DNYxNsqKqdsVw7-x8uVc05_fB0BcHfJU5rv-VtFUv7A@mail.gmail.com>	<m3zkjkugz9.fsf@fleche.redhat.com>	<CABc96T_dL8gN9LwtE+Gb_WuzAv1XvCaU+rbZkxhNb-Wb=EdBJw@mail.gmail.com>	<m339hatrqv.fsf@fleche.redhat.com>	<CABc96T-R-TY=T0KrnedV0hSyhLoa1=vuc_P9jwJ_gmEz4QjfJg@mail.gmail.com>	<m3bovxqmc2.fsf@fleche.redhat.com>
Date: Fri, 12 Aug 2011 17:12:00 -0000
Message-ID: <CABc96T939QWVZw0fqAiDeCNLJY2n1xWzN3XFbdg2DgW2aQGvjA@mail.gmail.com>
Subject: Re: [PATCH] [JAVA] Double.parseDouble(null) throw NullPointerException
From: Jie Liu <lj8175@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: java-patches@gcc.gnu.org, gcc-patches@gcc.gnu.org, 	Joel Sherrill <joel.sherrill@oarcorp.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2011-q3/txt/msg00070.txt.bz2

> If you did, then I don't know, you'll have to debug it, sorry.
>
> I vaguely recollect that -fcheck-references adds a check for 'this' at
> the start of final methods. =A0If I'm misremembering, then that is
> probably the problem.

In my debug, there appears no check for 'this' at start of String.length():

(gdb) s
java::lang::VMDouble::parseDouble (str=3D0x0)
    at ../../../gcc-trunk/libjava/java/lang/natVMDouble.cc:165
165	  int length =3D str->length();
(gdb) s
java.lang.String.length()int (this=3D@336e44)
    at /mnt/gcj/gcj-rtems-work/gcc-trunk/libjava/java/lang/String.java:451
451	    return count;
(gdb) p count
$5 =3D -268370093
(gdb) p this
$6 =3D (java.lang.String *) 0x0

Thanks,
Jie