From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24438 invoked by alias); 12 May 2014 16:07:30 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 24419 invoked by uid 89); 12 May 2014 16:07:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-qa0-f50.google.com Received: from mail-qa0-f50.google.com (HELO mail-qa0-f50.google.com) (209.85.216.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 12 May 2014 16:07:28 +0000 Received: by mail-qa0-f50.google.com with SMTP id j15so7179478qaq.37 for ; Mon, 12 May 2014 09:07:25 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.95.164 with SMTP id i33mr37471001qge.6.1399910845706; Mon, 12 May 2014 09:07:25 -0700 (PDT) Received: by 10.96.235.108 with HTTP; Mon, 12 May 2014 09:07:25 -0700 (PDT) In-Reply-To: References: Date: Mon, 12 May 2014 16:07:00 -0000 Message-ID: Subject: Re: [PATCH] Enable Java on Cygwin-64 From: Kai Tietz To: Bernd Edlinger Cc: "gcc-patches@gcc.gnu.org" , "java-patches@gcc.gnu.org" , Rainer Orth Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2014-q2/txt/msg00018.txt.bz2 Hi, I have the following comment. boehm-gc/ChangeLog: 2014-05-11 Bernd Edlinger Fix current cygwin-64 build problems. * include/gc_config_macros.h (GC_PTHREADS): Use __CYGWIN__ instead of __CYGWIN32__ here. * win32_threads.c (GC_push_all_stacks): Push all X86_64 registers. (GC_get_thread_stack_base): Get the stack base for X86_64. That change is ok. Please don't miss to post the changes also to boehm-gc's ML. In general it is better to splitt patches into seprate patches. To put all in one isn't ease review here. libffi/ChangeLog: 2014-05-11 Bernd Edlinger Fix current cygwin-64 build problems. * src/java_raw_api.c: Remove if !defined(FFI_NO_RAW_API). * src/x86/ffi.c: Add if defined(__CYGWIN__). * src/x86/win64.S (ffi_closure_win64, ffi_call_win64): Added handling for FFI_TYPE_UINT64, FFI_TYPE_POINTER and FFI_TYPE_INT. Added SEH information. Fixed formatting. Patch is ok IMO. Nevertheless this part shall go also to libffi's ML. libgcc/ChangeLog: 2014-05-11 Bernd Edlinger * unwind-seh.c (_Unwind_Backtrace): Uncommented, finished implementation. This part of the patch is ok. Please apply to trunk. libjava/ChangeLog: 2014-05-11 Bernd Edlinger Fix current cygwin-64 build problems. * configure.host: Added handling for x86_64-*-cygwin/mingw. * boehm.cc (_Jv_GCAttachThread, _Jv_GCDetachThread): Don't compile if GC_WIN32_THREADS is defined. * java/lang/natClass.cc (_Jv_InterfaceAssignableFrom): Rename interface to source_interface. This part of the patch looks ok too. As here a libjava-maintainer needs to look into too, you should post this part again to ML with prominent marking libjava in subject line. libjava/classpath/ChangeLog: 2014-05-11 Bernd Edlinger Fix current cygwin-64 build problems. * native/fdlibm/mprec.c (_REENT_CHECK_MP, _REENT_MP_FREELIST, _REENT_MP_P5S, __ULong, __Long): Undefine previous definitions. Same here. Looks ok to me, too. Nevertheless please post it as separate thread to ML. Thanks, Kai