From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2823 invoked by alias); 18 Jul 2012 18:44:15 -0000 Received: (qmail 2796 invoked by uid 22791); 18 Jul 2012 18:44:14 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-yx0-f175.google.com (HELO mail-yx0-f175.google.com) (209.85.213.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 18:44:01 +0000 Received: by yenl13 with SMTP id l13so1993170yen.20 for ; Wed, 18 Jul 2012 11:44:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.75.162 with SMTP id d2mr1883366paw.59.1342637040435; Wed, 18 Jul 2012 11:44:00 -0700 (PDT) Received: by 10.66.11.130 with HTTP; Wed, 18 Jul 2012 11:44:00 -0700 (PDT) In-Reply-To: <20120718162727.GA23420@intel.com> References: <20120716201408.GA5091@intel.com> <20120718162727.GA23420@intel.com> Date: Wed, 18 Jul 2012 18:44:00 -0000 Message-ID: Subject: Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32 From: Uros Bizjak To: "H.J. Lu" Cc: java-patches@gcc.gnu.org, libffi-discuss@sourceware.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org X-SW-Source: 2012-q3/txt/msg00010.txt.bz2 On Wed, Jul 18, 2012 at 6:27 PM, H.J. Lu wrote: >> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32. >> It fixed: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982 > > Here is the patch with updated ChangeLog entry. X32 has the same issue > as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW: > > http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html > http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html > > The same fix is needed for x32. OK for trunk? > > 2012-07-16 H.J. Lu > > * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for > x32. > (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32. How did you tested this patch? Does it fix all the problems from PR53982, including the one that is not 100% reproducible? Uros.