From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-20548-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 20490 invoked by alias); 18 Jul 2012 19:13:58 -0000
Received: (qmail 20463 invoked by uid 22791); 18 Jul 2012 19:13:57 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_IB
X-Spam-Check-By: sourceware.org
Received: from mail-yx0-f175.google.com (HELO mail-yx0-f175.google.com) (209.85.213.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 19:13:36 +0000
Received: by yenl13 with SMTP id l13so2030016yen.20        for <multiple recipients>; Wed, 18 Jul 2012 12:13:36 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.66.79.195 with SMTP id l3mr2047861pax.33.1342638815976; Wed, 18 Jul 2012 12:13:35 -0700 (PDT)
Received: by 10.66.11.130 with HTTP; Wed, 18 Jul 2012 12:13:35 -0700 (PDT)
In-Reply-To: <CAMe9rOoOJVHV7XjpBSNDPi-T9_oiFCKkxc2uXADKGoR=N0=MCA@mail.gmail.com>
References: <20120716201408.GA5091@intel.com>	<20120718162727.GA23420@intel.com>	<CAFULd4YQZ90fR5Mby6JGtNFLjgtBga2rK2OdFzYn3_hNFHf4zQ@mail.gmail.com>	<CAMe9rOoOJVHV7XjpBSNDPi-T9_oiFCKkxc2uXADKGoR=N0=MCA@mail.gmail.com>
Date: Wed, 18 Jul 2012 19:13:00 -0000
Message-ID: <CAFULd4Za9_R6znB3khoqKh42L+npbwcUzRJ58g7mFef3OY-ZSw@mail.gmail.com>
Subject: Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32
From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: java-patches@gcc.gnu.org, libffi-discuss@sourceware.org, 	gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2012-q3/txt/msg00012.txt.bz2

On Wed, Jul 18, 2012 at 9:10 PM, H.J. Lu <hjl.tools@gmail.com> wrote:

>>>> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32.
>>>> It fixed:
>>>>
>>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982
>>>
>>> Here is the patch with updated ChangeLog entry.  X32 has the same issue
>>> as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW:
>>>
>>> http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html
>>> http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html
>>>
>>> The same fix is needed for x32.  OK for trunk?
>>>
>>> 2012-07-16  H.J. Lu  <hongjiu.lu@intel.com>
>>>
>>>         * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for
>>>         x32.
>>>         (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32.
>>
>> How did you tested this patch? Does it fix all the problems from
>> PR53982, including the one that is not 100% reproducible?
>>
>
> I tested it on Linux/x32. All libjava tests are passing now for x32 with
> this patch.

OK then.

Thanks,
Uros.