From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28687 invoked by alias); 12 Mar 2014 15:02:46 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 28676 invoked by uid 89); 12 Mar 2014 15:02:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 X-HELO: mail-oa0-f48.google.com Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 12 Mar 2014 15:02:44 +0000 Received: by mail-oa0-f48.google.com with SMTP id m1so10137153oag.7 for ; Wed, 12 Mar 2014 08:02:42 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.183.3.102 with SMTP id bv6mr39004543obd.18.1394636562284; Wed, 12 Mar 2014 08:02:42 -0700 (PDT) Received: by 10.182.137.136 with HTTP; Wed, 12 Mar 2014 08:02:42 -0700 (PDT) In-Reply-To: References: Date: Wed, 12 Mar 2014 15:02:00 -0000 Message-ID: Subject: Fwd: [PATCH, libjava]: Avoid suggest parentheses around comparison in operand of '|' in java/lang/natObject.cc From: Uros Bizjak To: java-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=001a1134a45ce37f1704f46a2070 X-SW-Source: 2014-q1/txt/msg00003.txt.bz2 --001a1134a45ce37f1704f46a2070 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1221 Forwarded from gcc-patches@ ML [1]. [1] http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00481.html ---------- Forwarded message ---------- From: Uros Bizjak Date: Mon, Mar 10, 2014 at 9:13 PM Subject: [PATCH, libjava]: Avoid suggest parentheses around comparison in operand of '|' in java/lang/natObject.cc To: "gcc-patches@gcc.gnu.org" Hello! During libjava build, following warning is reported: ../../../gcc-svn/branches/gcc-4_8-branch/libjava/java/lang/natObject.cc:932:27: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses] JvAssert(he -> address == address | LOCKED ); ^ It looks that parentheses are missing around (address | LOCKED), otherwise the expression is always true - LOCKED is unconditionally defined to 1. Attached patch adds these parentheses (and removes a pair of superfluous ones). 2014-03-10 Uros Bizjak * java/lang/natObject.cc (_Jv_MonitorEnter): Add missing parenthesis around comparison with (address | LOCKED) in JvAssert. Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu {,-m32}. OK for mainline SVN and release branches? Uros. --001a1134a45ce37f1704f46a2070 Content-Type: text/plain; charset=US-ASCII; name="j.diff.txt" Content-Disposition: attachment; filename="j.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hsm6t5pz0 Content-length: 1281 SW5kZXg6IGphdmEvbGFuZy9uYXRPYmplY3QuY2MKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gamF2YS9sYW5nL25hdE9iamVjdC5jYwkocmV2aXNpb24g MjA4NDU1KQorKysgamF2YS9sYW5nL25hdE9iamVjdC5jYwkod29ya2luZyBj b3B5KQpAQCAtOTI5LDcgKzkyOSw3IEBAIHJldHJ5OgogCSAgLy8gb25seSBi ZSBoZWxkIGJ5IG90aGVyIHRocmVhZHMgd2FpdGluZyBmb3IgY29udmVyc2lv biwgYW5kCiAJICAvLyB0aGV5LCBsaWtlIHVzLCBkcm9wIGl0IHF1aWNrbHkg d2l0aG91dCBibG9ja2luZy4KIAkgIF9Kdl9NdXRleExvY2soJihobC0+c2ku bXV0ZXgpKTsKLQkgIEp2QXNzZXJ0KGhlIC0+IGFkZHJlc3MgPT0gYWRkcmVz cyB8IExPQ0tFRCApOworCSAgSnZBc3NlcnQoaGUgLT4gYWRkcmVzcyA9PSAo YWRkcmVzcyB8IExPQ0tFRCkpOwogCSAgcmVsZWFzZV9zZXQoJihoZSAtPiBh ZGRyZXNzKSwgKGFkZHJlc3MgfCBSRVFVRVNUX0NPTlZFUlNJT04gfCBIRUFW WSkpOwogCQkJCS8vIHJlbGVhc2UgbG9jayBvbiBoZQogCSAgTE9HKFJFUV9D T05WLCAoYWRkcmVzcyB8IFJFUVVFU1RfQ09OVkVSU0lPTiB8IEhFQVZZKSwg c2VsZik7CkBAIC05NjEsNyArOTYxLDcgQEAgcmV0cnk6CiAgICAgfQogICBv YmpfYWRkcl90IHdhc19oZWF2eSA9IChhZGRyZXNzICYgSEVBVlkpOwogICBp ZiAoKGFkZHJlc3MgJiBMT0NLRUQpIHx8Ci0gICAgICAhY29tcGFyZV9hbmRf c3dhcCgmKGhlIC0+IGFkZHJlc3MpLCBhZGRyZXNzLCAoYWRkcmVzcyB8IExP Q0tFRCApKSkKKyAgICAgICFjb21wYXJlX2FuZF9zd2FwKCYoaGUgLT4gYWRk cmVzcyksIGFkZHJlc3MsIGFkZHJlc3MgfCBMT0NLRUQgKSkKICAgICB7CiAg ICAgICB3YWl0X3VubG9ja2VkKGhlKTsKICAgICAgIGdvdG8gcmV0cnk7Cg== --001a1134a45ce37f1704f46a2070--