From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30124 invoked by alias); 18 Oct 2013 15:42:13 -0000 Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: java-patches-owner@gcc.gnu.org Received: (qmail 30097 invoked by uid 89); 18 Oct 2013 15:42:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-we0-f172.google.com Received: from mail-we0-f172.google.com (HELO mail-we0-f172.google.com) (74.125.82.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 18 Oct 2013 15:42:12 +0000 Received: by mail-we0-f172.google.com with SMTP id q58so3983190wes.3 for ; Fri, 18 Oct 2013 08:42:08 -0700 (PDT) X-Received: by 10.180.12.45 with SMTP id v13mr3367237wib.57.1382110928747; Fri, 18 Oct 2013 08:42:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.217.137.132 with HTTP; Fri, 18 Oct 2013 08:41:48 -0700 (PDT) In-Reply-To: <87a9i7s48n.fsf@fleche.redhat.com> References: <20131018011541.GA29495@carrie.the212.com> <87a9i7s48n.fsf@fleche.redhat.com> From: =?UTF-8?B?QW5kw6/Drw==?= Date: Fri, 18 Oct 2013 15:42:00 -0000 Message-ID: Subject: Re: [PATCH] PR58669: does not detect all cpu cores/threads To: Tom Tromey Cc: Java Patch List , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2013-q4/txt/msg00002.txt.bz2 On 18 October 2013 03:27, Tom Tromey wrote: >>>>>> "Andrew" == Andrew writes: > > Andrew> +#ifdef HAVE_UNISTD_H > Andrew> + procs = sysconf(_SC_NPROCESSORS_ONLN); > Andrew> +#endif > > Space before the "(". > > Technically you should probably check for sysconf in configure.ac. > I'm not sure whether it matters any more. > > I think _SC_NPROCESSORS_ONLN is not portable though. > > Tom I can add an #ifdef _SC_NPROCESSORS_ONLN around it too. Is that enough to imply we have sysconf too? -- Andii :-)