From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <java-patches-return-20505-listarch-java-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 27777 invoked by alias); 28 Mar 2012 10:02:29 -0000
Received: (qmail 27762 invoked by uid 22791); 28 Mar 2012 10:02:28 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-iy0-f175.google.com (HELO mail-iy0-f175.google.com) (209.85.210.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Mar 2012 10:02:04 +0000
Received: by iaag37 with SMTP id g37so1309237iaa.20        for <multiple recipients>; Wed, 28 Mar 2012 03:02:04 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.50.161.225 with SMTP id xv1mr1546362igb.35.1332928924157; Wed, 28 Mar 2012 03:02:04 -0700 (PDT)
Received: by 10.42.165.132 with HTTP; Wed, 28 Mar 2012 03:02:04 -0700 (PDT)
In-Reply-To: <CABu31nN--GqGPuaGjqq6ZQBdNYwp0wkWO06A5NJ+fk1igig06g@mail.gmail.com>
References: <CABu31nPAkz+xn4OVa-N+zee0b44TYd-rqQgSVg=m7+NxOMyTqg@mail.gmail.com>	<201203272307.17027.ebotcazou@adacore.com>	<CABu31nOk3X1LXeFdq8UEyOvjmWuc3RKRtBtqg4cm7Wq51Ej9nw@mail.gmail.com>	<CABu31nN--GqGPuaGjqq6ZQBdNYwp0wkWO06A5NJ+fk1igig06g@mail.gmail.com>
Date: Wed, 28 Mar 2012 10:02:00 -0000
Message-ID: <CAFiYyc0NN9CpgEe8qrT3vt--qvXwd0ahJw=aeC7zZpXPpv-P_A@mail.gmail.com>
Subject: Re: [patch][rfa] Do not call output_constant from the front end
From: Richard Guenther <richard.guenther@gmail.com>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org, java-patches@gcc.gnu.org, 	Eric Botcazou <ebotcazou@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1
Mailing-List: contact java-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <java-patches.gcc.gnu.org>
List-Subscribe: <mailto:java-patches-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java-patches/>
List-Post: <mailto:java-patches@gcc.gnu.org>
List-Help: <mailto:java-patches-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Sender: java-patches-owner@gcc.gnu.org
X-SW-Source: 2012-q1/txt/msg00083.txt.bz2

On Wed, Mar 28, 2012 at 12:23 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Tue, Mar 27, 2012 at 11:51 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>> On Tue, Mar 27, 2012 at 11:07 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>>>> With this patch a variable named "_Jv_CLS" is written out. The
>>>> assembly before and after the patch is the same, except for the
>>>> variable name. I want to write out a nameless variable but I don't
>>>> know how.
>>>
>>> Try tree_output_constant_def.
>>
>> I didn't know about this function. But as far as I can tell, there is
>> no way to instruct that function to put the data in a specific
>> section. In the Java case, the data must be put in the .jcr section. I
>> suppose that can be achieved with a bit more re-working of varasm, but
>> not with the code as-is. Thanks for the pointer, though!
>
> It also doesn't appear to be possible to adjust the alignment via
> tree_output_constant_def(), so going down that path seems more trouble
> than it's worth.
>
> Therefore, an RFA for the attached patch. Bootstrapped&tested on
> powerpc64-unknown-linux-gnu. OK?

Ok.

Thanks for applying TLC to Java.

Richard.

> Ciao!
> Steven